[Bug 1417316] New: Review Request: perl-IO-Socket-Multicast - Perl library for sending and receiving multicast messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1417316

            Bug ID: 1417316
           Summary: Review Request: perl-IO-Socket-Multicast - Perl
                    library for sending and receiving multicast messages
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: nobody@xxxxxxxxxxxxxxxxx
          Reporter: zonexpertconsulting@xxxxxxxxxxx
        QA Contact: extras-qa@xxxxxxxxxxxxxxxxx
                CC: package-review@xxxxxxxxxxxxxxxxxxxxxxx



Description: 
The IO::Socket::Multicast module sub-classes IO::Socket::INET to enable you
to manipulate multicast groups. With this module (and an operating system
that supports multicast), you will be able to receive incoming multicast
transmissions and generate your own outgoing multicast packets.

Spec URL: 
https://raw.githubusercontent.com/knnniggett/specfiles/master/perl-IO-Socket-Multicast.spec

SRPM URL: 
https://copr-be.cloud.fedoraproject.org/results/kni/zoneminder_deps/fedora-26-x86_64/00504845-perl-IO-Socket-Multicast/perl-IO-Socket-Multicast-1.12-1.fc26.src.rpm


Fedora Account System Username: kni

Package currently builds on el6, el7, f24, f25, & rawhide.
About the license.
License is Perl 5 (Artistic 1 & GPL 1) as stated here:
http://search.cpan.org/~bramble/IO-Socket-Multicast-1.12/

License is also stated in Makefile.PL

However, there is no license information in any of the source files which are
actually installed onto the target filesystem. In my quest to determine whether
or not this was sufficient, I went looking for an existing packaging in the
Fedora repos in a similar predicament, and I found perl-IO-Socket-SSL. Since
“the other package is doing it”, I thought it good enough for peer review.
Please advise if this is sufficient or not. I can certainly contact the author
if needed.

rpmlint produces no errors or warnings:
$ rpmlint perl-IO-Socket-Multicast-1.12-1.fc26.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint perl-IO-Socket-Multicast-1.12-1.fc26.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Package Contents:
$ rpm -q -lv -p perl-IO-Socket-Multicast-1.12-1.fc26.x86_64.rpm
drwxr-xr-x    2 root    root                        0 Jan 27 15:04
/usr/lib64/perl5/vendor_perl/IO
drwxr-xr-x    2 root    root                        0 Jan 27 15:04
/usr/lib64/perl5/vendor_perl/IO/Socket
-rw-r--r--    1 root    root                    14201 Apr 28  2010
/usr/lib64/perl5/vendor_perl/IO/Socket/Multicast.pm
drwxr-xr-x    2 root    root                        0 Jan 27 15:04
/usr/lib64/perl5/vendor_perl/auto/IO
drwxr-xr-x    2 root    root                        0 Jan 27 15:04
/usr/lib64/perl5/vendor_perl/auto/IO/Socket
drwxr-xr-x    2 root    root                        0 Jan 27 15:04
/usr/lib64/perl5/vendor_perl/auto/IO/Socket/Multicast
-rwxr-xr-x    1 root    root                    15424 Jan 27 15:04
/usr/lib64/perl5/vendor_perl/auto/IO/Socket/Multicast/Multicast.so
drwxr-xr-x    2 root    root                        0 Jan 27 15:04
/usr/share/doc/perl-IO-Socket-Multicast
-rw-r--r--    1 root    root                     1796 Apr 28  2010
/usr/share/doc/perl-IO-Socket-Multicast/Changes
-rw-r--r--    1 root    root                    11649 Jan 29  2010
/usr/share/doc/perl-IO-Socket-Multicast/README
drwxr-xr-x    2 root    root                        0 Apr 28  2010
/usr/share/doc/perl-IO-Socket-Multicast/examples
-rw-r--r--    1 root    root                      370 Jan 29  2010
/usr/share/doc/perl-IO-Socket-Multicast/examples/client.pl
-rw-r--r--    1 root    root                      359 Jan 29  2010
/usr/share/doc/perl-IO-Socket-Multicast/examples/server.pl
-rw-r--r--    1 root    root                     5346 Jan 27 15:04
/usr/share/man/man3/IO::Socket::Multicast.3pm.gz

Requires:
$ rpm -q --requires -p perl-IO-Socket-Multicast-1.12-1.fc26.x86_64.rpm
libc.so.6()(64bit)
libc.so.6(GLIBC_2.2.5)(64bit)
libc.so.6(GLIBC_2.4)(64bit)
libperl.so.5.24()(64bit)
perl(:MODULE_COMPAT_5.24.1)
perl(:VERSION) >= 5.5.0
perl(Carp)
perl(DynaLoader)
perl(Exporter)
perl(IO::Interface) >= 0.94
perl(IO::Socket)
perl(strict)
perl(vars)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
rtld(GNU_HASH)

Provides:
$ rpm -q --provides -p perl-IO-Socket-Multicast-1.12-1.fc26.x86_64.rpm
perl(IO::Socket::Multicast) = 1.12
perl-IO-Socket-Multicast = 1.12-1.fc26
perl-IO-Socket-Multicast(x86-64) = 1.12-1.fc26

Needed Buildrequires for perl test:
$ tangerine Multicast.pm
Carp
    COMPILE /usr/lib64/perl5/vendor_perl/IO/Socket/Multicast.pm:5
DynaLoader
    COMPILE /usr/lib64/perl5/vendor_perl/IO/Socket/Multicast.pm:7
Exporter
    COMPILE /usr/lib64/perl5/vendor_perl/IO/Socket/Multicast.pm:6
IO::Socket
    COMPILE /usr/lib64/perl5/vendor_perl/IO/Socket/Multicast.pm:8
IO::Socket::Multicast
    PACKAGE /usr/lib64/perl5/vendor_perl/IO/Socket/Multicast.pm:1
strict
    COMPILE /usr/lib64/perl5/vendor_perl/IO/Socket/Multicast.pm:4
vars
    COMPILE /usr/lib64/perl5/vendor_perl/IO/Socket/Multicast.pm:12

Test::More and IO::Interface >= 0.94 are also needed for perl test

SIDE NOTE:
Looks like this package was requested previously but I don't see anything in
that request to prevent the package from being approved:
https://bugzilla.redhat.com/show_bug.cgi?id=735045

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux