[Bug 1417405] Review Request: prelude-lml

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1417405



--- Comment #2 from Thomas Andrejak <thomas.andrejak@xxxxxxxxx> ---
Hello

Thanks for the review

SPEC : https://fedorapeople.org/~totol/prelude-lml.spec
SRPM : https://fedorapeople.org/~totol/prelude-lml-3.1.0-1.fc26.src.rpm

(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> It'd drop stuff like %{__mkdir_p} → mkdir -p is just as good. It's not like
> anyone is ever going to rebuild this rpm on a system without a working
> mkdir. IMHO, doing stuff like that is just an obsolete legacy of configure
> scripts from 80's and 90's. (Same for chrpath, install.) In addition, it's
> ugly to use the macro in one place, and then write 'mkdir -p' a few lines
> down.

Done

> 
> %config %{_unitdir}/%{name}.service → nope, that's not config. Just a normal
> file. If somebody needs to tweak it, they should place stuff in /etc/systemd.
> 

Done (I read it too fast ...)

> Hm, on my 12-core system, test-lock runs and runs and runs (currently 21h+
> of CPU time). I'll fire of another build on koji, let's see how that goes.

Yes I had this one time with koji. I don't know why and I can't reproduce it.
Plus, I never see this happens on another system, just with koji. I have to
cancel and then start the task again and it pass.

> 
> rpmlint:
> prelude-lml.x86_64: W: crypto-policy-non-compliance-gnutls-1
> /usr/sbin/prelude-lml gnutls_priority_set_direct

As I said in first message, false positive, I fixed it with a patch

> 
> prelude-lml.x86_64: W: non-ghost-in-run /run/prelude-lml
> Not sure about this one. I couldn't find anything in the guidelines, and a
> few packages I looked at do not use %ghost. I guess that if you want the
> directory to be available immediately after the package is installed,
> current version is reasonable. Seems OK as is.

Guidelines : https://fedoraproject.org/wiki/Packaging:Tmpfiles.d , see the spec
example. I don't know which is the right way

> 
> Let's see if it builds in koji:
>  https://koji.fedoraproject.org/koji/taskinfo?taskID=17483847

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]