https://bugzilla.redhat.com/show_bug.cgi?id=1417405 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- It'd drop stuff like %{__mkdir_p} → mkdir -p is just as good. It's not like anyone is ever going to rebuild this rpm on a system without a working mkdir. IMHO, doing stuff like that is just an obsolete legacy of configure scripts from 80's and 90's. (Same for chrpath, install.) In addition, it's ugly to use the macro in one place, and then write 'mkdir -p' a few lines down. %config %{_unitdir}/%{name}.service → nope, that's not config. Just a normal file. If somebody needs to tweak it, they should place stuff in /etc/systemd. Hm, on my 12-core system, test-lock runs and runs and runs (currently 21h+ of CPU time). I'll fire of another build on koji, let's see how that goes. rpmlint: prelude-lml.x86_64: W: crypto-policy-non-compliance-gnutls-1 /usr/sbin/prelude-lml gnutls_priority_set_direct prelude-lml.x86_64: W: non-ghost-in-run /run/prelude-lml Not sure about this one. I couldn't find anything in the guidelines, and a few packages I looked at do not use %ghost. I guess that if you want the directory to be available immediately after the package is installed, current version is reasonable. Seems OK as is. Let's see if it builds in koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=17483847 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx