https://bugzilla.redhat.com/show_bug.cgi?id=1359402 --- Comment #33 from Tim Fenn <tim.fenn@xxxxxxxxx> --- (In reply to Antonio Trande from comment #32) > - Please, remove empty sections (%check, %clean) > Done. > - Since Python sub-directory is named 'coot', i think it's better naming the > related packages as python2-coot. > Done. > I guess, it's a nonsense packaging two symlinks, so please erase > python2-coot-devel. Sorry, i had not realized this before. > No worries, fixed. > Also, add the 'python-provide' macro to python2-coot > %{?python_provide:%python_provide python2-%{name}} > Done. > - Please, don't use hardcoded-library-path: > > RDKIT_CXXFLAGS="-I/usr/include/rdkit -DRDKIT_HAS_CAIRO_SUPPORT" --> > RDKIT_CXXFLAGS="-I%{_includedir}/rdkit -DRDKIT_HAS_CAIRO_SUPPORT" > Fixed. https://timfenn.fedorapeople.org/coot.spec https://timfenn.fedorapeople.org/coot-0.8.7-3.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx