https://bugzilla.redhat.com/show_bug.cgi?id=1411188 Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(randy@electronswe | |atshop.com) | --- Comment #2 from Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> --- Thanks for the notes Remi! I'm sure it's obvious to you that this is my first PHP package, so I really don't know much about what I'm doing. I used to code in PHP, but I haven't done that since 2004 and my has it changed since then (and how much I've forgotten anyway!) ☺ Responses inline. (In reply to Remi Collet from comment #1) > Quick notes > > > Requires: php >= 5.2.0 > > No, it doesn't requires this (this is mod_php, which pull apache) > => Use php(language) Corrected. > > %global commit 662d62a7 > > => use full reference Fixed. > > %setup -q -n %{name}-662d62a7df1247515572bf517e14b795714e0824 > > => Use previous macro Fixed. > => So you need to requires php-curl, php-date, php-json, php-spl and php-xml Fixed. > Nice to have a simple autoload.php (see tests/bootstrap for content), which > can be maintained downstream if some day upstream drop it, and thus maintain > compatibility. I copied the one from tests/bootstrap and adjusted it to match what I thought made sense. I'd love your input on what I did there, since I've not done PHP in so long. > Also use phpunit --boostrap=%{buildroot}/usr/share.... > So "installed" code will be tested instead of code from sources tree. Fixed. > ** This looks like a dead project, no commit since 2013, no release. ** > > Do you really need this and want to maintain it ? > (btw, test suite passes with PHP 5.6, 7.0 and 7.1) So my goal here is to get Ampache packaged for Fedora. I've been working off of Ampache's composer.json to find its dependencies, and that's how I knew I needed this package: https://github.com/ampache/ampache/blob/develop/composer.json What do you think? Here are some new files: Spec URL: https://bowlofeggs.fedorapeople.org/php-echonest-api.spec SRPM URL: https://bowlofeggs.fedorapeople.org/php-echonest-api-0-0.2.git.662d62a7.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx