https://bugzilla.redhat.com/show_bug.cgi?id=1411188 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxxxxxxxxx, | |randy@xxxxxxxxxxxxxxxxxxxxx Flags| |needinfo?(randy@electronswe | |atshop.com) --- Comment #1 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- Quick notes > Requires: php >= 5.2.0 No, it doesn't requires this (this is mod_php, which pull apache) => Use php(language) > %global commit 662d62a7 => use full reference > %setup -q -n %{name}-662d62a7df1247515572bf517e14b795714e0824 => Use previous macro >From phpcompatinfo report Extensions Analysis Extension Matches REF EXT min/Max PHP min/Max PHP all Core Core 5.1.0 5.1.0 curl curl 5.1.3 5.1.3 date date 4.0.0 4.0.0 json json 5.2.0 5.2.0 spl spl 5.1.2 5.1.2 standard standard 4.0.7 4.0.7 xml xml 4.0.0 4.0.0 Total [7] 5.2.0 => So you need to requires php-curl, php-date, php-json, php-spl and php-xml Seems to be PSR-0 compliant, so a PSR-0 tree is /usr/share/php/EchoNest (but really not a problem, as we don't rely on this anymore, rather on autoloaders) Nice to have a simple autoload.php (see tests/bootstrap for content), which can be maintained downstream if some day upstream drop it, and thus maintain compatibility. Also use phpunit --boostrap=%{buildroot}/usr/share.... So "installed" code will be tested instead of code from sources tree. Not registered on packagist (so probably no very commonly used) ** This looks like a dead project, no commit since 2013, no release. ** Do you really need this and want to maintain it ? (btw, test suite passes with PHP 5.6, 7.0 and 7.1) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx