https://bugzilla.redhat.com/show_bug.cgi?id=1403600 --- Comment #3 from Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx> --- (In reply to Michael Schwendt from comment #2) > > Source0: > > Source1: > > 404 not found Fixed > > > > %package blender > > Summary: Blender integration scripts > > Requires: %{name} = %{version}-%{release} > > Since there are arch-specific builds in these packages: > https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package Added to the spec > > > The build will not work but I think this is a place to provide > > guidance and suggestion. > > Uhm, the build will not work? Why submit a package for review that doesn't > even try to build, because the top sourcedir isn't found? > > RPM build errors: > + cd YafaRay-3.1.1 > /var/tmp/rpm-tmp.p0hraO: line 37: cd: YafaRay-3.1.1: No such file or > directory > > Obviously, you need to adjust the name of the top sourcedir, which is > Core-3.1.1-beta and not the default %{name}-%{version}. The correct sourcedir is in place. However, I hit an issue with opencv which somehow failed due to some missing headers even though the right dependency is fulfilled. See https://koji.fedoraproject.org/koji/watchlogs?taskID=17253204 and the result https://koji.fedoraproject.org/koji/taskinfo?taskID=17253202 Suggestion welcome. > You haven't even mentioned anything in the %changelog about the upgrade from > 0.0.1 to 3.1.1 Beta. My bad. I forgot mention upgrade from upstream. > > > %{_libdir}/%{yname}/*.so > > %{_libdir}/libyafaraycore.so > > https://fedoraproject.org/wiki/Packaging: > Guidelines#File_and_Directory_Ownership > https://fedoraproject.org/wiki/Packaging:UnownedDirectories > > Also for both [sub]packages and the libs installed into global %{_libdir}: > https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries Fixed. A relic of the old packaging method. Here is the updated files Spec URL: https://luya.fedorapeople.org/packages/SPECS/YafaRay.spec SRPM URL: https://luya.fedorapeople.org/packages/SRPMS/YafaRay-3.1.1-0.2.beta.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx