[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1403600



--- Comment #2 from Michael Schwendt <bugs.michael@xxxxxxx> ---
> Source0:
> Source1:

404 not found


> %package blender
> Summary: Blender integration scripts
> Requires: %{name} = %{version}-%{release}

Since there are arch-specific builds in these packages:
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package


> The build will not work but I think this is a place to provide
> guidance and suggestion.

Uhm, the build will not work? Why submit a package for review that doesn't even
try to build, because the top sourcedir isn't found?

  RPM build errors:
  + cd YafaRay-3.1.1
  /var/tmp/rpm-tmp.p0hraO: line 37: cd: YafaRay-3.1.1: No such file or
directory

Obviously, you need to adjust the name of the top sourcedir, which is
Core-3.1.1-beta and not the default %{name}-%{version}.

You haven't even mentioned anything in the %changelog about the upgrade from
0.0.1 to 3.1.1 Beta.


> %{_libdir}/%{yname}/*.so
> %{_libdir}/libyafaraycore.so

https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
https://fedoraproject.org/wiki/Packaging:UnownedDirectories

Also for both [sub]packages and the libs installed into global %{_libdir}:
https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]