https://bugzilla.redhat.com/show_bug.cgi?id=1406786 Ricardo Cordeiro <ricardo.cordeiro@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christos.triantafyllidis@gm | |ail.com Whiteboard| |AwaitingSubmitter Flags| |needinfo?(christos.triantaf | |yllidis@xxxxxxxxx) --- Comment #3 from Ricardo Cordeiro <ricardo.cordeiro@xxxxxxxxxx> --- Hi Christos, Please review the following official review results. Once you're ready for a 2nd pass, please drop "AwaitingSubmitter" from the Whiteboard. Thanks. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== [x]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed "The %defattr directive in the %files list SHOULD ONLY be used when setting a non-default value, or to reset to the default value after having set a non-default value." Reference: https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions I would recommend removing it per guidelines but I will not fail this review if it remains unchanged. [!]: Package obeys FHS, except libexecdir and /usr/target. /usr/bin/configsnap fails to run if not done as root. This being the case, it should be placed under /usr/sbin instead Ref.: http://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch04s10.html [!]: Package meets the Packaging Guidelines::Python "Packages in Fedora should not depend on where /usr/bin/python happens to point but instead should call the proper executable for the needed python major version directly, either /usr/bin/python2 or /usr/bin/python3 as appropriate." Ref.: https://fedoraproject.org/wiki/Packaging:Python#Multiple_Python_Runtimes /usr/bin/configsnap's shebang is set to /usr/bin/python, I would suggest upstream to change this or alternatively patch the source when packaging the for Fedora and EPEL as it has been done for unoconv http://pkgs.fedoraproject.org/cgit/rpms/unoconv.git/tree/ Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 5 files have unknown license. Detailed output of licensecheck in /home/makerpm/reviews/configsnap/1406786-configsnap/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== [?] - getData script provided by upstream is not included. I understand that its purpose is limited as it only serves to warn the user that the script has been renamed to configsnap. I guess you've not included it by design, although, if included, /usr/bin/getdata would not collide with any current packages on Fedora, RHEL and EPEL repositories. Please confirm that this was done by design. Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: configsnap-0.11-1.fc23.noarch.rpm configsnap-0.11-1.fc23.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- configsnap (rpmlib, GLIBC filtered): /usr/bin/python Provides -------- configsnap: configsnap Source checksums ---------------- https://github.com/rackerlabs/configsnap/archive/0.11.tar.gz : CHECKSUM(SHA256) this package : c86e15ed04029afda3d0c3221e0cbde208c5e1315d89d1af0724970499790ec0 CHECKSUM(SHA256) upstream package : c86e15ed04029afda3d0c3221e0cbde208c5e1315d89d1af0724970499790ec0 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1406786 -P Python -D EPEL6 used: fedora-23-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx