[Bug 1412128] Review Request: libpreludedb - Prelude DB Library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1412128



--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
It'd be nice to rewrap the %description's. They are very unevenly indented.

> Provides:       %{name}%{?_isa}-devel = %{version}-%{release}
> Provides:       prelude-devel = %{version}-%{release}
That's a bit unusual. Automatically generated provides are usually enough. Why
is this needed?

make distcheck → %make_build distcheck. This will add -j..., which should make
the whole thing faster. Also, I'm not sure if running "distcheck" is
appropriate. "check" should be enough. "distcheck" is for tarball creators to
make sure that all the necessary files are included in the distribution, and
takes much more time because of the additional rebuild.

There seems to be some codepage corruption in changelog: Caolán McNamara →
Caolán McNamara, Marcela MaÅ¡láňová → Marcela Mašláňová.

Looks great though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]