[Bug 1409654] Review Request: python-pydocstyle - Python docstring style checker

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1409654

Filip Szymański <fszymanski@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fszymanski@xxxxxxx



--- Comment #5 from Filip Szymański <fszymanski@xxxxxxx> ---
Hi,

In this case I have to agree with Igor, it would be better to use the GitHub
source. It contains tests and all files have Unix line endings (conversion
unnecessary). Use the tarball and not the zip archive.
Correct source URL:
Source0: 
https://github.com/PyCQA/%{srcname}/archive/%{version}/%{srcname}-%{version}.tar.gz

Things like removing shebang from a file or dos2unix should be done in the
%prep section.

What's up with the Release tag (0%{?dist}.1)?
Should be:
Release:  1%{?dist}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]