https://bugzilla.redhat.com/show_bug.cgi?id=1409884 --- Comment #2 from Igor Gnatenko <ignatenko@xxxxxxxxxx> --- Hey Brian, 1. I would recommend to change name of package to something in lower-case (https://fedoraproject.org/wiki/Packaging:Naming#General_Naming) 2. Missing BuildRequires: gcc (all BuildRequires must be specified) 3. Since upstream uses pkg-config to find dependencies (PKG_CHECK_MODULES(DAYJOURNAL, gee-0.8 [gtk+-3.0 libnotify appindicator3-0.1 gio-2.0 gdk-3.0 gtk+-3.0 glib-2.0])), it's worth to change style of BuildRequires: pkgconfig(gtk+-3.0) pkgconfig(libnotify) ... and remaining ones 4. if you will rename package to dayjornal, then you can drop "-n ..." part in %autosetup -n dayjournal-%{version} 5. cp %{SOURCE1} . doesn't preserve timestamps (you can add `-a` to cp invocation) 6. make %{?_smp_mflags} -> %make_build (this is preferred because of some switches in parallel building inside RPM) 7. install -m 644 -D dayjournal.desktop %{buildroot}/usr/share/applications/dayjournal.desktop 7.1. Add `-p` to preserve timestamps 7.2. Use %{name} instead of dayjornal if you will rename it 7.3. replace /usr/share with %{_datadir} 8. %make_install install-exec, is it really needed to specify install-exec? 9. /usr/share/icons/hicolor/48x48/apps/dayjournal-icon.png 9.1. same to replace /usr/share with %{_datadir} 9.2. I think having "-icon" is pointless 10. You should run desktop-file-validate against desktop file in %check section 11. License is GPLv3+, not GPLv3 Unfortunately I can't sponsor you, so you have to find it yourself. But I'm happy to help you to make package ready for inclusion! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx