[Bug 1409867] Review Request: python2-btchip - 'btchip-python' is a library used to interface with Ledger hardware devices ( Cryptocurrency)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1409867



--- Comment #3 from Mike Goodwin <mike@xxxxxxxxxxxx> ---
(In reply to Jonny Heggheim from comment #1)
> You should split the package like described here:
> https://fedoraproject.org/wiki/Packaging:Python#Common_SRPM_vs_split_SRPMs
> 
> You should also use the template used in the Example common spec file
> section on the Packaging Guidelines for Python. The one you use is to
> support older EPEL versions.
> 

This library does not yet support python3, so is the preferred method then to
use the common spec here:
https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file and
then just comment out all the python3 related items?

> Fedora Packaging Guidelines for Python:
> > If a piece of software supports python3, it must be packaged for python3.
> Lets see if it works with python3. If not then we do not build it.
> 

It doesn't 

> 
> >Source0: https://github.com/LedgerHQ/%{srcname}/archive/v%{version}.tar.gz
> This is a personal preference, but I like to download the release from the
> Python Package Index / pythonhosted.org, since that is what upstream publish.

I'd prefer to stay with github if it's all the same. I have it added here as
well: https://release-monitoring.org/project/12767/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]