https://bugzilla.redhat.com/show_bug.cgi?id=1408428 --- Comment #3 from Till Hofmann <till.hofmann@xxxxxxxxx> --- Spec URL: https://thofmann.fedorapeople.org/log4cxx/log4cxx.spec SRPM URL: https://thofmann.fedorapeople.org/log4cxx/log4cxx-0.10.0-22.fc23.src.rpm Thank you for reviewing! (In reply to Antonio Trande from comment #2) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > > Issues: > ======= > - Package does not use a name that already exists. > Note: A package with this name already exists. Please check > https://admin.fedoraproject.org/pkgdb/package/log4cxx > See: > > https://fedoraproject.org/wiki/Packaging/ > NamingGuidelines#Conflicting_Package_Names > > - No Requires: %{name}%{?_isa} = %{version}-%{release} in log4cxx-devel > > Use Requires: '%{name}%{?_isa} = %{version}-%{release}' Fixed. > > - Use '--enable-static=no' as configure's option to not build static files > (*.a) Fixed. > > - make -k %{?_smp_mflags} > > Why that -k option? Oversight. I replaced it with %make_build. > > - Please, fix 'unused-direct-shlib-dependency' warnings Fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx