[Bug 1262515] Review Request: qbs - Qt Build Suite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1262515



--- Comment #12 from Michael Schwendt <bugs.michael@xxxxxxx> ---
(!) 404 not found for the src.rpm


> # Required for running the tests
> BuildRequires:  pkgconfig(Qt5Quick)
> BuildRequires:  glibc-static
> BuildRequires:  libstdc++-static

Hmmm. Does the comment above that also refer to the two -static packages?

Why would tests require linking statically?

Since BuildRequires apply to the entire package, the availability of the static
libs in the buildroot can be problematic due to linking other executables
statically (either accidentally, unknowingly or because of build defaults
changing eventually). That would be something to avoid by adding guards or
finding ways to eliminate static linking in those tests.

https://fedoraproject.org/wiki/Packaging:Guidelines#Statically_Linking_Executables

[...]

Has "fedora-review -b 1262515" been run for this ticket yet?

[...]

> %package doc
> %package examples

If these shall stay completely separate subpackages, consider fixing the
directory ownership and %license usage for these packages.

* https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
*
https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux