https://bugzilla.redhat.com/show_bug.cgi?id=1404043 --- Comment #4 from Jarod Wilson <jarod@xxxxxxxxxx> --- Spec file comments from honli: Url: https://github.com/linux-rdma/rdma-core honli: https://fedoraproject.org/wiki/Packaging:SourceURL#When_Upstream_uses_Prohibited_Code honli: Please add comment for the "Source:" tag. Source: rdma-core-%{version}.tgz BuildRequires: binutils BuildRequires: cmake >= 2.8.11 BuildRequires: gcc BuildRequires: libudev-devel BuildRequires: pkgconfig BuildRequires: pkgconfig(libnl-3.0) BuildRequires: pkgconfig(libnl-route-3.0) BuildRequires: valgrind-devel honli: libnl3-devel is required for iwpmd libibverbs honli: systemd and dracut also needed. honli: You also delete a few necessary "Requires:" tags. honli: Please see review-comment.txt for details. %description RDMA core userspace infrastructure and documentation. honli: I know this is an upstream issue. This is %description honli: section is too simple, in other words, it is meaningless. honli: If you do not have good %description section, I suggest honli: you copy and paste https://bugzilla.redhat.com/show_bug.cgi?id=1404043#c0 honli: At least, user will know what is the package after read that. %package -n libibverbs Summary: A library and drivers for direct userspace use of RDMA (InfiniBand/iWARP) hardware Requires(post): /sbin/ldconfig Requires(postun): /sbin/ldconfig Requires: rdma-core honli: Even over 99% files are stext files, rdma-core contains /usr/sbin/rdma-ndd, honli: which is an ELF file, so rdma-core is not a noarch rpm. Please replace all honli: "Requires: rdma-core" with "Requires: %{name}%{?_isa} = %{version}-%{release}" %description -n srp_daemon In conjunction with the kernel ib_srp driver, srptools allows you to honli: should replace srptools with srp_daemon in above line? discover and use SCSI devices via the SCSI RDMA Protocol over InfiniBand. %prep %setup honli: %setup -q ??? %build %postun -n ibacm %systemd_postun_with_restart ibacm.service honli: Why you only run systemd_post/systemd_preun/systemd_postun_with_restart honli: against ibacm.service? How about iwpmd.service and srp_daemon.service? %post -n libibcm -p /sbin/ldconfig %postun -n libibcm -p /sbin/ldconfig honli: Why not run ldconfig for other libraries, at least librdmacm has .so honli: file in private dir. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx