https://bugzilla.redhat.com/show_bug.cgi?id=1404043 --- Comment #3 from Jarod Wilson <jarod@xxxxxxxxxx> --- (In reply to Jarod Wilson from comment #2) > From honli via email, pasting here for all to see: > > Issue 1: see line 11 > honli@dhcp47-85:~/b1404043/1404043-rdma-core/srpm-unpacked/rdma-core-12$ cat > -n MAINTAINERS > 1 List of maintainers > 2 > 3 Generally patches should be submitted to the main development > mailing list: > 4 > 5 linux-rdma@xxxxxxxxxxxxxxx > 6 > 7 Descriptions of section entries: > 8 F: Files and directories with wildcard patterns. > 9 A trailing slash includes all files and subdirectory > files. > 10 F: providers/mlx4/ all files in and below > providers/mlx4/ > 11 F: providers/* all files in drivers/net, but not > below <---- drivers/net??? Upstream typo. Will send a patch. > Issue 2: Why remove the manpage? > [honli@dhcp47-85 srp]$ diff -Nurp > ./usr/lib/systemd/system/srp_daemon.service > /home/honli/rhel-scm/srptools/srptools.service > --- ./usr/lib/systemd/system/srp_daemon.service 2016-12-19 > 03:48:07.774866479 -0500 > +++ /home/honli/rhel-scm/srptools/srptools.service 2016-04-11 > 21:33:29.905060849 -0400 > @@ -1,6 +1,6 @@ > [Unit] > Description=Start or stop the daemon that attaches to SRP devices > -Documentation=man:srp_daemon file:/etc/rdma/rdma.conf > file:/etc/srp_daemon.conf > +Documentation=file:///etc/rdma/rdma.conf file:///etc/srp_daemon.conf > DefaultDependencies=false > Conflicts=emergency.target emergency.service > Requires=rdma.service Already since resolved upstream, commit 9317fbb01ac2ef33a4570c66b1e651ab71d07b90. > Issue 3: please use the new name > 189 %description -n srp_daemon > 190 In conjunction with the kernel ib_srp driver, srptools allows you to > <--- s/srptools/srp_daemon/ > 191 discover and use SCSI devices via the SCSI RDMA Protocol over InfiniBand. Will send a patch upstream. > Issue 4: broken soft link (librdmacm-12-1.fc26.x86_64.rpm)? > /usr/lib64/rsocket > [honli@dhcp47-85 rsocket]$ ll > total 0 > lrwxrwxrwx. 1 honli honli 15 Dec 20 00:37 librspreload.so.1 -> > librspreload.so > lrwxrwxrwx. 1 honli honli 15 Dec 20 00:37 librspreload.so.1.0.0 -> > librspreload.so This looks like an upstream problem, just doing a build in a freshly unpacked tree sans-rpm has similar results. I'll address it there. > Issue 5: missing BuildRequires This was better explained elsewhere, it's really just "don't explicitly list gcc" here, which I'll send a patch upstream for. > Issue 6: missing "Requires: tags" > Please see comment-rdma-core.spec. Will address this separately shortly. > Question 1: > /usr/lib/systemd/system/srpd.service --> > /usr/lib/systemd/system/srp_daemon.service > The service had been named as "srpd" since 2009, should we keep the old name? I'd stick with following upstream. > Question 2: why libibacmp.so.* removed for new ibacm-12-1.fc26 pkg? > (libibcm.f26 keeps libibcm.so.1.0.12) > 14 /usr/lib64/ibacm/libibacmp.so | 14 > /usr/lib64/ibacm/libibacmp.so > 15 /usr/lib64/ibacm/libibacmp.so.1 | > ------------------------------------------------- > 16 /usr/lib64/ibacm/libibacmp.so.1.0.0 | > ------------------------------------------------- This is an upstream change as well. I believe libibacmp is only intended for internal use by ibacm. > Comment 1: > /etc/rc.d/init.d/srpd (delete it as RHEL7 and FC26 use systemd.) Confused here, I don't see this in the build. Or did you mean "this is getting removed from the old version, but it's fine"? > Comment 2: iwpmd no longer start after syslog.target, as it does not write > any log files. iwpmd send log message to /var/log/messages. > diff -Nurp iwpmd-1.0.6-2.el7/usr/lib/systemd/system/iwpmd.service > iwpmd-12-1.fc26/usr/lib/systemd/system/iwpmd.service > --- iwpmd-1.0.6-2.el7/usr/lib/systemd/system/iwpmd.service 2016-12-19 > 20:55:43.377778756 -0500 > +++ iwpmd-12-1.fc26/usr/lib/systemd/system/iwpmd.service 2016-12-19 > 20:56:55.874779421 -0500 > @@ -1,12 +1,12 @@ > [Unit] > -Description=Starts the IWPMD daemon > -Documentation=file:///usr/share/doc/iwpmd/README > -After=network.target syslog.target <--- > +Description=iWarp Port Mapper > +Documentation=man:iwpmd file:/etc/iwpmd.conf > +After=network.target Is this another "this is a change to take note of" thing? Just using the upstream .service file here. > Comment 3: > AUTHORS files had been removed, but we have a new file "MAINTAINERS" for > such info. Indeed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx