https://bugzilla.redhat.com/show_bug.cgi?id=1401967 --- Comment #6 from Sandro Mani <manisandro@xxxxxxxxx> --- Created attachment 1233252 --> https://bugzilla.redhat.com/attachment.cgi?id=1233252&action=edit patch I've tried a build against Qt5/quazip-qt5 and it built fine with the patch attached. The src/3rdparty/qt-labs-qtscriptgenerator-5.7.1/qt-labs-qtscriptgenerator-5.7.1.pro patch is probably better handled in the spec by generating a symlink according to the qt version in use. I also added $$shadowed to allow building outside the source tree, it is not strictly necessary though. If you can confirm the program works, please build against Qt5 instead of the obsolete Qt4. And about the actual unbundling of qtscriptgenerator: it looks like the code has diverged a lot from the (seemingly pretty dead) upstream, so just add Provides: bundled(qtscriptgenerator) with a comment that the code has diverged. I'd also add bundled provides for dxflib, stemmer and opennurbs: even if they are not currently in Fedora, they might get added in the future. What I meant with $RPM_BUILD_ROOT -> %{buildroot} is to replace all $RPM_BUILD_ROOT occurences with %{buildroot}. I thought fedora-review warned about this, but I see now that the warning is just to not mix $RPM_BUILD_ROOT and %{buildroot}. So up to you which variant you prefer. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx