https://bugzilla.redhat.com/show_bug.cgi?id=1401967 --- Comment #5 from Antonio Trande <anto.trande@xxxxxxxxx> --- (In reply to Sandro Mani from comment #4) > - Can the repo version of spatialindex, quazip and qt-labs-qtscriptgenerator > be used instead of the bundled copies? If yes, please patch the build > scripts to do so, otherwise add a comment justifying why and add the > corresponding bundled virtual provides. qcad does not compile with quazip from Fedora and, honestly, i don't know how to unbundle qt-labs-qtscriptgenerator. > > - Do not mix $ and % variables (i.e. $RPM_BUILD_ROOT -> %{buildroot}) ?? > > - Could desktop and appdata be provided as separate sources for better SPEC > legibility? Done. Spec URL: https://sagitter.fedorapeople.org/qcad/qcad.spec SRPM URL: https://sagitter.fedorapeople.org/qcad/qcad-3.15.6.1-2.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx