https://bugzilla.redhat.com/show_bug.cgi?id=1403417 --- Comment #7 from Joël Krähemann <jkraehemann@xxxxxxxxx> --- Hi Just updated gsequencer.spec and have taken a look at the review. About certain points I'm unsure. This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/jkraehemann/1403417-gsequencer/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL - Package uses either %{buildroot} or $RPM_BUILD_ROOT Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [?]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated", "MIT/X11 (BSD like)", "FSF Unlimited GPL", "*No copyright* FSF All Permissive", "FSF All Permissive", "FSF Unlimited". 146 files have unknown license. Detailed output of licensecheck in /home/jkraehemann/1403417-gsequencer/licensecheck.txt [?]: License file installed when any subpackage combination is installed. [?]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gtk-doc, /usr/share/xml [?]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/doc/libags-doc (gsequencer-devel-doc, gsequencer-devel-docs), /usr/share/doc/libags- audio-doc(gsequencer-devel-doc, gsequencer-devel-docs), /usr/share/doc /libags-audio-doc/api(gsequencer-devel-doc, gsequencer-devel-docs), /usr/share/doc/libags-gui-doc/api(gsequencer-devel-doc, gsequencer- devel-docs), /usr/share/doc/libags-doc/api(gsequencer-devel-doc, gsequencer-devel-docs), /usr/share/doc/libags-gui-doc(gsequencer- devel-doc, gsequencer-devel-docs), /usr/share/gtk-doc/html(harfbuzz- devel, gtk-doc) [?]: %build honors applicable compiler flags or justifies otherwise. [?]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [?]: Package consistently uses macros (instead of hard-coded directory names). [?]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [?]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [?]: Useful -debuginfo package or justification otherwise. [?]: Package is not known to require an ExcludeArch tag. [?]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 153600 bytes in 3 files. [?]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [?]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [?]: Final provides and requires are sane (see attachments). [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gsequencer-debuginfo , gsequencer-devel-doc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [?]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [?]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 9093120 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gsequencer-0.7.115-0.fc25.x86_64.rpm gsequencer-debuginfo-0.7.115-0.fc25.x86_64.rpm gsequencer-devel-0.7.115-0.fc25.x86_64.rpm gsequencer-devel-doc-0.7.115-0.fc25.x86_64.rpm gsequencer-0.7.115-0.fc25.src.rpm gsequencer.x86_64: W: shared-lib-calls-exit /usr/lib64/libags.so.0.0.7 exit@GLIBC_2.2.5 gsequencer.x86_64: W: devel-file-in-non-devel-package /usr/lib64/gsequencer/libgsequencer.so gsequencer-devel.x86_64: W: only-non-binary-in-usr-lib gsequencer-devel.x86_64: W: no-documentation gsequencer.src: W: file-size-mismatch gsequencer-0.7.115.tar.gz = 2927360, http://download.savannah.gnu.org/releases/gsequencer/0.7.x/gsequencer-0.7.115.tar.gz = 2795351 5 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (debuginfo) ------------------- Checking: gsequencer-debuginfo-0.7.115-0.fc25.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_gui.so.0.0.7 /lib64/libgmodule-2.0.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_gui.so.0.0.7 /lib64/libgthread-2.0.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_gui.so.0.0.7 /lib64/libgdk_pixbuf-2.0.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_gui.so.0.0.7 /lib64/libgio-2.0.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_gui.so.0.0.7 /lib64/libfontconfig.so.1 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_gui.so.0.0.7 /lib64/libfreetype.so.6 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_gui.so.0.0.7 /lib64/librt.so.1 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_gui.so.0.0.7 /lib64/libdl.so.2 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_gui.so.0.0.7 /lib64/libX11.so.6 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_gui.so.0.0.7 /lib64/libpthread.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_server.so.0.0.7 /lib64/libuuid.so.1 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_server.so.0.0.7 /lib64/libxml2.so.2 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_server.so.0.0.7 /lib64/libgmodule-2.0.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_server.so.0.0.7 /lib64/libgthread-2.0.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_server.so.0.0.7 /lib64/libags_thread.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_server.so.0.0.7 /lib64/librt.so.1 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_server.so.0.0.7 /lib64/libm.so.6 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_server.so.0.0.7 /lib64/libdl.so.2 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_server.so.0.0.7 /lib64/libX11.so.6 gsequencer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libags.so.0.0.7 ags_mutex_manager_get_instance gsequencer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libags.so.0.0.7 ags_mutex_manager_get_application_mutex gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags.so.0.0.7 /lib64/libgmodule-2.0.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags.so.0.0.7 /lib64/libgthread-2.0.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags.so.0.0.7 /lib64/librt.so.1 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags.so.0.0.7 /lib64/libdl.so.2 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags.so.0.0.7 /lib64/libX11.so.6 gsequencer.x86_64: W: shared-lib-calls-exit /usr/lib64/libags.so.0.0.7 exit@GLIBC_2.2.5 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_audio.so.0.0.7 /lib64/libgmp.so.10 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_audio.so.0.0.7 /lib64/libuuid.so.1 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_audio.so.0.0.7 /lib64/libgmodule-2.0.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_audio.so.0.0.7 /lib64/libgthread-2.0.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_audio.so.0.0.7 /lib64/libX11.so.6 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_thread.so.0.0.7 /lib64/libuuid.so.1 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_thread.so.0.0.7 /lib64/libgmodule-2.0.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_thread.so.0.0.7 /lib64/libgthread-2.0.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_thread.so.0.0.7 /lib64/libdl.so.2 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_thread.so.0.0.7 /lib64/libX11.so.6 gsequencer.x86_64: W: devel-file-in-non-devel-package /usr/lib64/gsequencer/libgsequencer.so gsequencer-devel.x86_64: W: only-non-binary-in-usr-lib gsequencer-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 40 warnings. Requires -------- gsequencer (rpmlib, GLIBC filtered): /sbin/ldconfig ld-linux-x86-64.so.2()(64bit) libX11.so.6()(64bit) libags.so.0()(64bit) libags_audio.so.0()(64bit) libags_gui.so.0()(64bit) libags_server.so.0()(64bit) libags_thread.so.0()(64bit) libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libasound.so.2(ALSA_0.9.0rc4)(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libdl.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgmp.so.10()(64bit) libgobject-2.0.so.0()(64bit) libgsequencer.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libinstpatch-1.0.so.0()(64bit) libjack.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libsamplerate.so.0()(64bit) libsamplerate.so.0(libsamplerate.so.0.0)(64bit) libsndfile.so.1()(64bit) libsndfile.so.1(libsndfile.so.1.0)(64bit) libuuid.so.1()(64bit) libuuid.so.1(UUID_1.0)(64bit) libuuid.so.1(UUID_2.20)(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) rtld(GNU_HASH) gsequencer-devel-doc (rpmlib, GLIBC filtered): gsequencer-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config gsequencer(x86-64) libags.so.0()(64bit) libags_audio.so.0()(64bit) libags_gui.so.0()(64bit) libags_server.so.0()(64bit) libags_thread.so.0()(64bit) pkgconfig(alsa) pkgconfig(cairo) pkgconfig(fontconfig) pkgconfig(gdk-pixbuf-2.0) pkgconfig(gio-2.0) pkgconfig(glib-2.0) pkgconfig(gmodule-2.0) pkgconfig(gobject-2.0) pkgconfig(gthread-2.0) pkgconfig(gtk+-2.0) pkgconfig(jack) pkgconfig(libags) pkgconfig(libinstpatch-1.0) pkgconfig(libxml-2.0) pkgconfig(sndfile) pkgconfig(uuid) gsequencer-debuginfo (rpmlib, GLIBC filtered): Provides -------- gsequencer: application() application(gsequencer.desktop) gsequencer gsequencer(x86-64) libags.so.0()(64bit) libags_audio.so.0()(64bit) libags_gui.so.0()(64bit) libags_server.so.0()(64bit) libags_thread.so.0()(64bit) libgsequencer.so.0()(64bit) gsequencer-devel-doc: gsequencer-devel-doc gsequencer-devel-doc(x86-64) gsequencer-devel: gsequencer-devel gsequencer-devel(x86-64) pkgconfig(libags) pkgconfig(libags_audio) pkgconfig(libags_gui) gsequencer-debuginfo: gsequencer-debuginfo gsequencer-debuginfo(x86-64) Unversioned so-files -------------------- gsequencer: /usr/lib64/gsequencer/libgsequencer.so Source checksums ---------------- http://download.savannah.gnu.org/releases/gsequencer/0.7.x/gsequencer-0.7.115.tar.gz : CHECKSUM(SHA256) this package : 78768e952709470241a2891942fbb2f3009467ba079f93c556a95ecb71f40dbf CHECKSUM(SHA256) upstream package : b702dd1ec3abe7a71a9c465c56227def3bed5075a11aba897cb22811ec946137 diff -r also reports differences Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1403417 Buildroot used: fedora-25-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx