https://bugzilla.redhat.com/show_bug.cgi?id=1402164 --- Comment #3 from Michael Schwendt <bugs.michael@xxxxxxx> --- > I have made as little changes to the original rpms as possible. Why that? What changes would you have liked to make? > Summary: Fully colorized df clone written in python s/python/Python/ > %install > rm -rf $RPM_BUILD_ROOT https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections > install -p pydf $RPM_BUILD_ROOT%{_bindir} > install -p pydfrc $RPM_BUILD_ROOT%{_sysconfdir} > install -p pydf.1 $RPM_BUILD_ROOT%{_mandir}/man1 These commands are the obvious place where to use the -m argument to set the mode of the files. > gzip -9nf $RPM_BUILD_ROOT%{_mandir}/man1/pydf.1 README rpm-builds compresses manual pages on-the-fly, choosing whatever compression technique is configured on the build machine. Don't compress the file manually. And compressing the 1992 bytes small README into a renamed file README.gz serves no purpose. It doesn't even save a KiB. > %clean > rm -rf $RPM_BUILD_ROOT https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections > %defattr(644,root,root,755) https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions > %doc README.gz INSTALL COPYING https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text > %attr(755,root,root) %{_bindir}/pydf If installed correctly during %install (either via an upstream Makefile or manually with the "install" command), it would not be necessary to fiddle with %attr here. Sure, using %attr works, but imagine you need to maintain a larger package with many more files. Overusing %attr reduces readability a lot. You want to reduce the usage to really special permission/owner change scenarios. > %{_mandir}/man1/pydf.1.gz As above. The following would be able to handle uncompressed man pages as well as system-wide rpmbuild configuration changes: %{_mandir}/man1/pydf.1* -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx