https://bugzilla.redhat.com/show_bug.cgi?id=1369708 --- Comment #61 from Yunying Sun <yunying.sun@xxxxxxxxx> --- (In reply to Dan Horák from comment #60) > formal review is here, see the notes explaining OK* and BAD statuses below: > ... > So almost good, but please answer my question (and/or prepare a new > iteration) before I'll approve the package. Thanks for the formal review and comments, Dan. I've updated SPEC & SRPM after fixing most issues you listed. Updated SPEC: https://raw.githubusercontent.com/yunyings/share/master/tpm2-tss.spec Updated SRPM: https://github.com/yunyings/share/blob/master/tpm2-tss-1.0-2.el7.src.rpm?raw=true COPR build(not yet finished): https://copr.fedorainfracloud.org/coprs/yunyings/tpm2-tss/build/487392/ > - a test directory is present in the source archive, can it be used (with > --enable-unit)? If it isn't used, then pkgconfig(cmocka) can be removed from > BR I suppose. Confirmed with upstream developer(Gang Wei) that test source code is not suggested to add into distro package, because "the software should be well tested before a formal upstream releasing, and the unit test code are just intended to help developer addressing wrong changes to the code." So no change for this. Questions left: 1. > N/A* %check is present and all tests pass. Is the %check section a MUST? 2. koji build always fail with certification failure(re-fetched cert through fedora-packager-setup for couple of times but error remains same), and COPR build is still pending after being submitted for over 2 hours. Is there something wrong known with Koji & COPR build servers today? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx