https://bugzilla.redhat.com/show_bug.cgi?id=1369708 --- Comment #60 from Dan Horák <dan@xxxxxxxx> --- formal review is here, see the notes explaining OK* and BAD statuses below: OK source files match upstream: c610fa5273909394fa54174afcd7541a5c87d16b TPM2.0-TSS-1.0.tar.gz OK package meets naming and versioning guidelines. OK* specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK license field matches the actual license. OK license is open source-compatible. License text included in package. OK latest version is being packaged. OK* BuildRequires are proper. OK compiler flags are appropriate. OK package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. OK* rpmlint is silent. OK final provides and requires look sane. N/A* %check is present and all tests pass. OK shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK headers in devel. OK pkgconfig files in devel. OK no libtool .la droppings. OK not a GUI app. - the %pkg_version macro is redundant, it contains the same value as %version - instead of ExcludeArch, that's currently incomplete (doesn't include eg. mips or s390) "ExclusiveArch: %{ix86} x86_64" should be used, exactly per the reason stated in comment above the tag - it's useful to write entries for directories with trailing slash, eg. %{_includedir}/sapi/ - makes visible to the reader it's a directory - also useful is to be more specific (less wildcards) in entries like %{_libdir}/*.so.* - better control about what changed in the upstream project - during the review process please increase the %release tag value for every revision of the package published, it allows to see what changed - autoconf and automake can be dropped from BuildRequires (libtool brings them in), similar for pkgconfig (pkgconfig(cmocka) will bring it in) - rpmlint complains a bit, but it can be ignored tpm2-tss.x86_64: W: invalid-license TCGL tpm2-tss.x86_64: W: no-manual-page-for-binary resourcemgr tpm2-tss-devel.x86_64: W: invalid-license TCGL tpm2-tss-devel.x86_64: W: only-non-binary-in-usr-lib tpm2-tss-devel.x86_64: W: no-documentation tpm2-tss.src: W: invalid-license TCGL tpm2-tss-debuginfo.x86_64: W: invalid-license TCGL 4 packages and 0 specfiles checked; 0 errors, 7 warnings. - a test directory is present in the source archive, can it be used (with --enable-unit)? If it isn't used, then pkgconfig(cmocka) can be removed from BR I suppose. So almost good, but please answer my question (and/or prepare a new iteration) before I'll approve the package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx