https://bugzilla.redhat.com/show_bug.cgi?id=1359914 --- Comment #23 from Jeremy Newton <alexjnewt@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/lollypop/lollypop-sp See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)", "*No copyright* CC by-sa (v3.0)", "MIT/X11 (BSD like)", "Unknown or generated", "CC by-sa (v3.0)", "FSF All Permissive". 149 files have unknown license. > The MIT and FSF All Permissive are install scripts, not source code. > This is a non-issue in my opinion [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/help/he, /usr/share/help/sk [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/help/fi, /usr/share/help/he, /usr/share/help/uk, /usr/share/help/de, /usr/share/help/sk, /usr/share/dbus-1/services, /usr/share/gnome-shell /search-providers, /usr/share/help/sv, /usr/share/help/sr, /usr/share/help/fr, /usr/share/help/C, /usr/share/help/nl, /usr/share/help/es, /usr/share/help/cs, /usr/share/help, /usr/share /gnome-shell, /usr/share/help/ca, /usr/share/help/pl, /usr/share/dbus-1, /usr/share/help/pt_BR, /usr/share/help/ru, /usr/share/help/it [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: glib-compile-schemas is run in %postun and %posttrans if package has *.gschema.xml files. Note: gschema file(s) in lollypop [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in lollypop [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in lollypop [-]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. > Music plays :) [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: lollypop-0.9.220-1.fc25.noarch.rpm lollypop-0.9.220-1.fc25.src.rpm lollypop.noarch: W: no-manual-page-for-binary lollypop lollypop.noarch: W: no-manual-page-for-binary lollypop-cli lollypop.noarch: W: no-manual-page-for-binary rhythmbox2lollypop 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- lollypop.noarch: W: no-manual-page-for-binary rhythmbox2lollypop lollypop.noarch: W: no-manual-page-for-binary lollypop lollypop.noarch: W: no-manual-page-for-binary lollypop-cli 1 packages and 0 specfiles checked; 0 errors, 3 warnings. > manpages would be nice, but are not mandatory. Requires -------- lollypop (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python3 gdk-pixbuf2 gobject-introspection gstreamer1-plugins-base gtk3 kid3-common libnotify pango pylast python(abi) python3-cairo python3-dbus python3-gobject python3-pylast python3-wikipedia Provides -------- lollypop: appdata() appdata(lollypop.appdata.xml) application() application(lollypop.desktop) lollypop mimehandler(application/ogg) mimehandler(application/x-ogg) mimehandler(application/x-ogm-audio) mimehandler(application/xspf+xml) mimehandler(audio/aac) mimehandler(audio/ac3) mimehandler(audio/flac) mimehandler(audio/m4a) mimehandler(audio/mp3) mimehandler(audio/mp4) mimehandler(audio/mpeg) mimehandler(audio/mpegurl) mimehandler(audio/ogg) mimehandler(audio/vnd.rn-realaudio) mimehandler(audio/vorbis) mimehandler(audio/x-aac) mimehandler(audio/x-flac) mimehandler(audio/x-m4a) mimehandler(audio/x-mp3) mimehandler(audio/x-mpeg) mimehandler(audio/x-mpegurl) mimehandler(audio/x-ms-wma) mimehandler(audio/x-musepack) mimehandler(audio/x-oggflac) mimehandler(audio/x-pn-realaudio) mimehandler(audio/x-scpls) mimehandler(audio/x-speex) mimehandler(audio/x-vorbis) mimehandler(audio/x-vorbis+ogg) mimehandler(audio/x-wav) mimehandler(x-content/audio-player) Source checksums ---------------- https://github.com/gnumdk/lollypop/releases/download/0.9.220/lollypop-0.9.220.tar.xz : CHECKSUM(SHA256) this package : df446133d8237c0061a6378958ae191cc9e3572248ca4593b3b4120c259a8c04 CHECKSUM(SHA256) upstream package : df446133d8237c0061a6378958ae191cc9e3572248ca4593b3b4120c259a8c04 Looks good, it's a pretty neat music player :)... but you should package the latest version before I can approve this. If you would like to package lollypop-portal separately, I can review it for you, but it's fine if you want to subpackage it instead. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx