https://bugzilla.redhat.com/show_bug.cgi?id=1398922 --- Comment #2 from Benjamin Kircher <benjamin.kircher@xxxxxxxxx> --- Thank you. > 1. No version specified in %changelog. Fixed. > Static libraries are discouraged. Add "--disable-static" in %configure, and add -devel package where *.so could be included. There are no static libraries in this package. The libmcount*.so files are actually needed to run the application and get loaded by the `uftrace` binary dynamically at run-time. I don't think this is really a plugin system but seems to work kind of the same way. > 3. Missing %doc for README.md. Fixed. > 4. Use %{name} instead of fixed string "uftrace" would be better in spec file. Fixed. New SPEC file: https://raw.githubusercontent.com/bkircher/uftrace-fedora/master/uftrace.spec New SRPM: https://raw.githubusercontent.com/bkircher/uftrace-fedora/master/uftrace-0.6-2.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx