https://bugzilla.redhat.com/show_bug.cgi?id=1398922 Yunying Sun <yunying.sun@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yunying.sun@xxxxxxxxx --- Comment #1 from Yunying Sun <yunying.sun@xxxxxxxxx> --- An unformal review: 1. No version specified in %changelog. changelog format: https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs 2. Static libraries are discouraged. Add "--disable-static" in %configure, and add -devel package where *.so could be included. Refer to: https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries https://fedoraproject.org/wiki/Packaging:Guidelines#DevelPackages 3. Missing %doc for README.md. 4. Use %{name} instead of fixed string "uftrace" would be better in spec file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx