[Bug 1397643] Review Request: dapl - Library providing access to the DAT 2.0 API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1397643



--- Comment #2 from Honggang LI <honli@xxxxxxxxxx> ---
(In reply to Michal Schmidt from comment #1)
> I suggest to drop all the Obsoletes lines:
Removed.

> 
> Before the ExcludeArch line:
>   ExcludeArch: s390, armv7hl
> maybe add a comment:
>   # Platforms missing in dapl/udapl/linux/dapl_osd.h
Added comment as required.

>   sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g'
> libtool
>   sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool
Replaced chrpath with this.

> Add BuildRequires for the C compiler.
Fixed.

Spec URL:
http://people.redhat.com/honli/.419dc6a07891d4da7bc03168d5613fcz/dapl.spec

SRPM URL:
http://people.redhat.com/honli/.419dc6a07891d4da7bc03168d5613fcz/dapl-2.1.9-2.fc26.src.rpm
Please review updated SPEC and SRPM files.

Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]