https://bugzilla.redhat.com/show_bug.cgi?id=1397643 Michal Schmidt <mschmidt@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |mschmidt@xxxxxxxxxx --- Comment #1 from Michal Schmidt <mschmidt@xxxxxxxxxx> --- I suggest to drop all the Obsoletes lines: Obsoletes: udapl < 1.3 Obsoletes: udapl-devel < 1.3 Obsoletes: dapl-devel-static < 2.0.24 They are pointless in Fedora where the obsoleted packages were never included. And even if we later inherit this dapl.spec into RHEL, we do not need these Obsoletes anymore, because RHEL 6.0 already had a new enough version of dapl, i.e. dapl-2.0.25. No need to try to support upgrades from earlier versions. Before the ExcludeArch line: ExcludeArch: s390, armv7hl maybe add a comment: # Platforms missing in dapl/udapl/linux/dapl_osd.h Instead of using chrpath, which the Fedora packaging guidelines describe as "a last resort", please switch to the recommended way of removing rpath (http://fedoraproject.org/wiki/Packaging:Guidelines#Removing_Rpath) - do this after %configure: sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' libtool sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool Add BuildRequires for the C compiler. (http://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B#BuildRequires_and_Requires) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx