[Bug 1383416] Review Request: python-influxdb - InfluxDB Python client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1383416



--- Comment #7 from David Hannequin <david.hannequin@xxxxxxxxx> ---
Hi,

* [!]: License field in the package spec file matches the actual license.
License field should have the correct name of the license, which in this case
is just `MIT` (https://fedoraproject.org/wiki/Licensing:MIT?rd=Licensing/MIT).
This will also fix the rpmlint errors:
    python3-influxdb.noarch: W: invalid-license MIT License
    python2-influxdb.noarch: W: invalid-license MIT License

I don't understand MIT licence seem valid. 

* [!]: Requires correct, justified where necessary.
Please be more specific in (Build)Requires and put python2-* instead of just
python- wherever it is possible. E.g. python2-setuptools, python2-requests

I fix this issue.

* You can use macro %{summary}, which will contain content of the Summary tag
(it's generated automatically, you do not have to define it). Just keep the
first Summary tag as it is and in python2/3- subpackages you can use `Summary: 
 %{summary}`.

I use macro %{summary}

Best regard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]