Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ruby-RMagick - Graphics Processing for Ruby and Ruby on Rails https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246716 ------- Additional Comments From kwizart@xxxxxxxxx 2007-07-13 08:44 EST ------- Ok im' not very experienced in ruby. here are few comments: *%define rubyabi 1.8 Is this a hardrequires or is it possible to have someting like in python: %{expand: %%define pyver %(python -c 'import sys;print(sys.version[0:3])')} * why does this is needed : %define repoid 21576 ? * Why do you have BuildRequires: ruby and ruby-devel ? * About # 1. First hack ImageMagick font configuration Does this is a special tweak for RMagick or this could be fixed in ImageMagick pacakge ? build.log: * Why theses dependencies aren't found ? checking for AdaptiveBlurImageChannel... no checking for AdaptiveResizeImage... no ... checking for GetColorHistogram... no checking for GetColorInfoArray... no ... checking for GetImageStatistics... no checking for GetMagickInfoArray... no ... checking for GrayscalePseudoClassImage... no checking for InterpolatePixelColor... no checking for IsImageSimilar... no checking for LinearStretchImage... no checking for OrderedPosterizeImageChannel... no checking for PolaroidImage... no checking for QuantumOperatorRegionImage... no checking for RecolorImage... no checking for SetImageRegistry... no checking for SketchImage... no checking for UniqueImageColors... no checking for PaletteBilevelMatteType enum value... no ... checking if GetImageQuantumDepth has only 1 argument... no checking if GetColorInfoList has only 2 arguments... no checking if GetTypeInfoList has only 2 arguments... no checking if GetMagickInfoList has only 2 arguments... no checking if ColorInfo.color is a MagickPixelPacket... no * -doc Installed docs in $(pwd)/Trash are the same as thoses present in doc from source - good But do # 3. clean up is needed to prevent thoses files to be installed ? Are they installed in $(pwd)/Trash ? Why not to use instead (for -doc) %doc Trash/* * naming - I don't know if this is mandatory but -docs is sometime choosen instead of -doc for documentation sub-package... * rpmlint on installed file is quiet -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review