https://bugzilla.redhat.com/show_bug.cgi?id=1396819 --- Comment #9 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Thomas Andrejak from comment #8) > For %doc and manpages, in > https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages the example do > not put the %doc macro. That's why I said it. The wiki is wrong ? There's no clear-cut guideline. In the example it's a page in section 1, so it makes some sense to install it even with --nodoc. It is also quite likely that %doc was simply forgotten. It's hard to say. Also note that the example is just that, it's the text that is authoritative. > > - %build > > Why are you forcing cflags instead of making patchs ? > > Hm, I don't understand. Why should I make patches? > => I don't think that overwriting CFLAGS is a good thing because the > environment can set it. (I may think wrong). For example for hardening. So I > try to never do this and prefer patch makefile or other file to do what I > need to do. To patch, to sed, or to set variables, is just a mechanism. Most things can be achieved with any of them, it's just a question which is the most convenient. In this case, I'd say, settings CLFAGS *is* that. Note that the hardening flags are used (via %optflags). This should always be verified by looking at the build log: gcc -fPIC -std=gnu99 -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -fwrapv -fvisibility=hidden -c -o kdf.o kdf.c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx