https://bugzilla.redhat.com/show_bug.cgi?id=1396819 --- Comment #8 from Thomas Andrejak <thomas.andrejak@xxxxxxxxx> --- For %doc and manpages, in https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages the example do not put the %doc macro. That's why I said it. The wiki is wrong ? > - %build > Why are you forcing cflags instead of making patchs ? Hm, I don't understand. Why should I make patches? => I don't think that overwriting CFLAGS is a good thing because the environment can set it. (I may think wrong). For example for hardening. So I try to never do this and prefer patch makefile or other file to do what I need to do. > - manpage should go to main package I don't think so. Those are all man pages in section 3, only useful for development. => Also in https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages , the example put manpage in main package. But you are right, this man page is for developpeurs, not users. I agree with you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx