https://bugzilla.redhat.com/show_bug.cgi?id=1382332 --- Comment #2 from Christian Dersch <lupinix@xxxxxxxxxxx> --- Hi, thx for your comment. Sorry for answering that late, just forgot it... (In reply to Dominika Krejčí from comment #1) > Hello Christian, I have some comments: > > * It is useless to create a %{sum} macro. Just write the content to > `Summary` and in the rest of the file you can use %{summary} macro. ;) Definitely not useless. We have subpackages here where the summary macro is overwritten (by itself). It is also common practice to write python specs that way, check https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file > > * `%description` should contain more comprehensive description then > `Summary`. > > * The file `PKG-INFO` is not a license. ("If the source package does not > include license text(s) as a separate file from upstream, the packager > SHOULD query upstream to include it.") True, I wrote upstream but got no reply yet. So I decided to add PKG_INFO to %license because at least it contains an information about the license. > > * If you run rpmlint, you will get many errors and warnings. Some of them: > > python3-axolotl-curve25519.x86_64: W: summary-not-capitalized C curve25519 > with ed25519 signatures > python3-axolotl-curve25519.x86_64: W: no-documentation > python3-axolotl-curve25519.x86_64: E: script-without-shebang > /usr/share/licenses/python3-axolotl-curve25519/PKG-INFO > python3-axolotl-curve25519.x86_64: E: script-without-shebang > /usr/lib64/python3.5/site-packages/python_axolotl_curve25519-0.1-py3.5.egg- > info/dependency_links.txt > python3-axolotl-curve25519.x86_64: E: script-without-shebang > /usr/lib64/python3.5/site-packages/python_axolotl_curve25519-0.1-py3.5.egg- > info/PKG-INFO > python3-axolotl-curve25519.x86_64: E: script-without-shebang > /usr/lib64/python3.5/site-packages/python_axolotl_curve25519-0.1-py3.5.egg- > info/top_level.txt > python3-axolotl-curve25519.x86_64: E: script-without-shebang > /usr/lib64/python3.5/site-packages/python_axolotl_curve25519-0.1-py3.5.egg- > info/SOURCES.txt > ... False positives, e.g. PKG_INFO is not a script, so it cannot be a script-without-shebang. I always check my stuff using rpmlint, but it is often complaining where it should not. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx