https://bugzilla.redhat.com/show_bug.cgi?id=1382332 Dominika Krejčí <dkrejci@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dkrejci@xxxxxxxxxx --- Comment #1 from Dominika Krejčí <dkrejci@xxxxxxxxxx> --- Hello Christian, I have some comments: * It is useless to create a %{sum} macro. Just write the content to `Summary` and in the rest of the file you can use %{summary} macro. ;) * `%description` should contain more comprehensive description then `Summary`. * The file `PKG-INFO` is not a license. ("If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.") * If you run rpmlint, you will get many errors and warnings. Some of them: python3-axolotl-curve25519.x86_64: W: summary-not-capitalized C curve25519 with ed25519 signatures python3-axolotl-curve25519.x86_64: W: no-documentation python3-axolotl-curve25519.x86_64: E: script-without-shebang /usr/share/licenses/python3-axolotl-curve25519/PKG-INFO python3-axolotl-curve25519.x86_64: E: script-without-shebang /usr/lib64/python3.5/site-packages/python_axolotl_curve25519-0.1-py3.5.egg-info/dependency_links.txt python3-axolotl-curve25519.x86_64: E: script-without-shebang /usr/lib64/python3.5/site-packages/python_axolotl_curve25519-0.1-py3.5.egg-info/PKG-INFO python3-axolotl-curve25519.x86_64: E: script-without-shebang /usr/lib64/python3.5/site-packages/python_axolotl_curve25519-0.1-py3.5.egg-info/top_level.txt python3-axolotl-curve25519.x86_64: E: script-without-shebang /usr/lib64/python3.5/site-packages/python_axolotl_curve25519-0.1-py3.5.egg-info/SOURCES.txt ... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx