https://bugzilla.redhat.com/show_bug.cgi?id=1344276 --- Comment #11 from Ken Dreyer <ktdreyer@xxxxxxxxxxxx> --- It seems like you're mixing the Release value and Version values here? Release is a number that is "downstream" (Fedora) only. Other Fedora maintainers, like ProvenPackagers or Fedora rel-eng, will sometimes bump this Release integer, so it's not something you can completely keep in sync between Fedora downstream and Gluster upstream. It would be best to avoid having the Release number in your upstream tarballs. To put it another way, "v%{version}-%{release}.tar.gz" should just be "v%{version}.tar.gz" The "/usr/local/bin/gluster-replace-node" file should not be in /usr/local (see https://fedoraproject.org/wiki/Packaging:Guidelines#No_Files_or_Directories_under_.2Fsrv.2C_.2Fusr.2Flocal.2C_or_.2Fhome.2F.24USER) The license seems unclear here, because the "LICENSE" file from upstream is the GPLv2, but the .spec here says GPLv3. Which is it? Also, the LICENSE file should be included in the package, via the %license directive. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx