[Bug 1359402] Review Request: coot - crystallographic macromolecular building toolkit (unretire request )

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1359402



--- Comment #11 from Antonio Trande <anto.trande@xxxxxxxxx> ---
>OK, so just switch this to GPLv3+ and delete all the other stuff?
Yes.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package does not use a name that already exists.
  Note: A package with this name already exists. Please check
  https://admin.fedoraproject.org/pkgdb/package/coot
  See:
 
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names

- Main package requires libcoot, not viceversa:

...
Requires: compat-guile18
Requires: hicolor-icon-theme
Requires: refmac-dictionary
Requires: lib%{name}%{?_isa} = %{version}-%{release}  <---
...
%package -n libcoot
Summary: Library files for coot
Group: Development/Libraries
...
%package -n libcoot-devel
Summary: Header files and library for developing programs with coot
Requires: lib%{name}%{?_isa} = %{version}-%{release}  <---
Group: Development/Libraries

- License and doc should be under '%files -n libcoot'

...
%files -n libcoot
# libccp4mg-utils.so* is LGPLv2+
# libcoot-surface.so* is a mix of LGPLv2+ and GPLv3+
# all others are GPLv3+
%doc AUTHORS README
%license COPYING
%{_libdir}/*.so.*
%{python2_sitearch}/*.so.*
...

- Python libraries should be packed separately in an arched
  'python2-libcoot' sub-package (sorry, i didn't seen it before).

  Main package should require it.

- doc subpackage provides PDF files only, it should not require
  the main one in my opinion.

- Useless ldconfig:

 %post
/sbin/ldconfig
/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :

- coot-data ?

- I don't see any tests ran with 'make check'

- Please, remove commands and macros in the comments

- AutoTools: Obsoleted m4s found
  ------------------------------
    AM_PROG_CC_STDC found in: coot-0.8.6.2/configure.ac:38

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "LGPL (v2.1 or later) (with incorrect FSF address)", "LGPL",
     "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated",
     "MIT/X11 (BSD like)", "LGPL (v3 or later)", "LGPL (v2.1 or later)".
     513 files have unknown license. Detailed output of licensecheck in
     /home/sagitter/1359402-coot/licensecheck.txt
[?]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
     contains icons.
     Note: icons in coot
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[!]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: Uses parallel make %{?_smp_mflags} macro.
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libcoot
     , libcoot-devel , coot-doc , coot-debuginfo
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[!]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[?]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 86138880 bytes in /usr/share
     coot-0.8.6.2-1.fc26.x86_64.rpm:86138880
     See:
    
http://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines
[!]: Package should not use obsolete m4 macros
     Note: Some obsoleted macros found, see the attachment.
     See: https://fedorahosted.org/FedoraReview/wiki/AutoTools
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: coot-0.8.6.2-1.fc26.x86_64.rpm
          libcoot-0.8.6.2-1.fc26.x86_64.rpm
          libcoot-devel-0.8.6.2-1.fc26.x86_64.rpm
          coot-doc-0.8.6.2-1.fc26.noarch.rpm
          coot-debuginfo-0.8.6.2-1.fc26.x86_64.rpm
          coot-0.8.6.2-1.fc26.src.rpm
coot.x86_64: W: spelling-error %description -l en_US mmdb -> mm db, mm-db, DBMS
coot.x86_64: W: no-manual-page-for-binary pyrogen
libcoot.x86_64: W: spelling-error %description -l en_US macromolecular -> macro
molecular, macro-molecular, molecular
libcoot.x86_64: W: no-documentation
libcoot.x86_64: W: one-line-command-in-%post /sbin/ldconfig
libcoot.x86_64: W: one-line-command-in-%postun /sbin/ldconfig
libcoot-devel.x86_64: W: no-dependency-on libcoot/libcoot-libs/liblibcoot
libcoot-devel.x86_64: W: spelling-error %description -l en_US macromolecular ->
macro molecular, macro-molecular, molecular
libcoot-devel.x86_64: W: only-non-binary-in-usr-lib
libcoot-devel.x86_64: W: no-documentation
libcoot-devel.x86_64: W: dangling-relative-symlink
/usr/lib64/python2.7/site-packages/_pyrogen_swig.so _pyrogen_swig.so.0.0.0
libcoot-devel.x86_64: W: dangling-relative-symlink
/usr/lib64/python2.7/site-packages/pyrogen_boost.so pyrogen_boost.so.0.0.0
coot-doc.noarch: W: summary-not-capitalized C documentation PDF files for coot
coot-doc.noarch: W: spelling-error %description -l en_US macromolecular ->
macro molecular, macro-molecular, molecular
coot.src: W: spelling-error %description -l en_US mmdb -> mm db, mm-db, DBMS
coot.src: W: strange-permission reference-structures.tar.gz 444
coot.src: W: strange-permission coot.in 755
coot.src:7: W: macro-in-comment %files
coot.src:119: W: macro-in-comment %configure
coot.src:150: W: macro-in-comment %{buildroot}
coot.src:150: W: macro-in-comment %{_includedir}
coot.src:151: W: macro-in-comment %{buildroot}
coot.src:151: W: macro-in-comment %{_includedir}
coot.src:151: W: macro-in-comment %{buildroot}
coot.src:151: W: macro-in-comment %{_includedir}
coot.src:152: W: macro-in-comment %{buildroot}
coot.src:152: W: macro-in-comment %{_includedir}
coot.src:152: W: macro-in-comment %{buildroot}
coot.src:152: W: macro-in-comment %{_includedir}
coot.src:155: W: macro-in-comment %{buildroot}
coot.src:155: W: macro-in-comment %{python2_sitelib}
coot.src:156: W: macro-in-comment %{buildroot}
coot.src:156: W: macro-in-comment %{_datadir}
coot.src:156: W: macro-in-comment %{buildroot}
coot.src:156: W: macro-in-comment %{python2_sitelib}
coot.src:173: W: macro-in-comment %{buildroot}
coot.src:173: W: macro-in-comment %{_bindir}
6 packages and 0 specfiles checked; 0 errors, 37 warnings.




Rpmlint (debuginfo)
-------------------
Checking: coot-debuginfo-0.8.6.2-1.fc26.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
libcoot.x86_64: W: spelling-error %description -l en_US macromolecular -> macro
molecular, macro-molecular, molecular
libcoot.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libcoot-coord-utils.so.0.0.0 /lib64/libgslcblas.so.0
libcoot.x86_64: W: no-documentation
libcoot.x86_64: W: one-line-command-in-%post /sbin/ldconfig
libcoot.x86_64: W: one-line-command-in-%postun /sbin/ldconfig
libcoot-devel.x86_64: W: no-dependency-on libcoot/libcoot-libs/liblibcoot
libcoot-devel.x86_64: W: spelling-error %description -l en_US macromolecular ->
macro molecular, macro-molecular, molecular
libcoot-devel.x86_64: W: only-non-binary-in-usr-lib
libcoot-devel.x86_64: W: no-documentation
libcoot-devel.x86_64: W: dangling-relative-symlink
/usr/lib64/python2.7/site-packages/pyrogen_boost.so pyrogen_boost.so.0.0.0
libcoot-devel.x86_64: W: dangling-relative-symlink
/usr/lib64/python2.7/site-packages/_pyrogen_swig.so _pyrogen_swig.so.0.0.0
coot-doc.noarch: W: summary-not-capitalized C documentation PDF files for coot
coot-doc.noarch: W: spelling-error %description -l en_US macromolecular ->
macro molecular, macro-molecular, molecular
coot.x86_64: W: spelling-error %description -l en_US mmdb -> mm db, mm-db, DBMS
coot.x86_64: W: no-manual-page-for-binary pyrogen
5 packages and 0 specfiles checked; 0 errors, 15 warnings.



Requires
--------
libcoot (rpmlib, GLIBC filtered):
    /bin/sh
    coot
    libDepictor.so.1()(64bit)
    libDescriptors.so.1()(64bit)
    libFileParsers.so.1()(64bit)
    libForceField.so.1()(64bit)
    libForceFieldHelpers.so.1()(64bit)
    libGL.so.1()(64bit)
    libGraphMol.so.1()(64bit)
    libMolChemicalFeatures.so.1()(64bit)
    libRDGeneral.so.1()(64bit)
    libRDGeometryLib.so.1()(64bit)
    libSmilesParse.so.1()(64bit)
    libSubstructMatch.so.1()(64bit)
    libboost_python.so.1.60.0()(64bit)
    libc.so.6()(64bit)
    libcairo.so.2()(64bit)
    libccp4mg-surface.so.0()(64bit)
    libccp4mg-utils.so.0()(64bit)
    libclipper-ccp4.so.2()(64bit)
    libclipper-contrib.so.2()(64bit)
    libclipper-core.so.2()(64bit)
    libclipper-minimol.so.2()(64bit)
    libclipper-mmdb.so.2()(64bit)
    libcoot-AngleInfo.so.0()(64bit)
    libcoot-analysis.so.0()(64bit)
    libcoot-coord-extras.so.0()(64bit)
    libcoot-coord-utils.so.0()(64bit)
    libcoot-coords.so.0()(64bit)
    libcoot-db-main.so.0()(64bit)
    libcoot-geometry.so.0()(64bit)
    libcoot-ideal.so.0()(64bit)
    libcoot-lidia-core.so.0()(64bit)
    libcoot-ligand.so.0()(64bit)
    libcoot-map-heavy.so.0()(64bit)
    libcoot-map-utils.so.0()(64bit)
    libcoot-mini-mol.so.0()(64bit)
    libcoot-shelx.so.0()(64bit)
    libcoot-utils.so.0()(64bit)
    libcoot_py_restraints.so.0()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_4.0.0)(64bit)
    libgdk-x11-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgoocanvas.so.3()(64bit)
    libgsl.so.19()(64bit)
    libgslcblas.so.0()(64bit)
    libgtk-x11-2.0.so.0()(64bit)
    libm.so.6()(64bit)
    libmmdb2.so.0()(64bit)
    libpango-1.0.so.0()(64bit)
    libpng16.so.16()(64bit)
    libpng16.so.16(PNG16_0)(64bit)
    libpython2.7.so.1.0()(64bit)
    libsrfftw.so.2()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.1)(64bit)
    libstdc++.so.6(CXXABI_1.3.8)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    python(abi)
    rtld(GNU_HASH)

libcoot-devel (rpmlib, GLIBC filtered):
    coot
    libccp4mg-surface.so.0()(64bit)
    libccp4mg-utils.so.0()(64bit)
    libcoot-AngleInfo.so.0()(64bit)
    libcoot-analysis.so.0()(64bit)
    libcoot-cabuild.so.0()(64bit)
    libcoot-compat.so.0()(64bit)
    libcoot-coord-extras.so.0()(64bit)
    libcoot-coord-utils.so.0()(64bit)
    libcoot-coords.so.0()(64bit)
    libcoot-db-main.so.0()(64bit)
    libcoot-geometry.so.0()(64bit)
    libcoot-goograph.so.0()(64bit)
    libcoot-gtkgraph.so.0()(64bit)
    libcoot-high-res.so.0()(64bit)
    libcoot-ideal.so.0()(64bit)
    libcoot-isosurface.so.0()(64bit)
    libcoot-lidia-core.so.0()(64bit)
    libcoot-lidia.so.0()(64bit)
    libcoot-ligand.so.0()(64bit)
    libcoot-map-heavy.so.0()(64bit)
    libcoot-map-utils.so.0()(64bit)
    libcoot-mini-mol.so.0()(64bit)
    libcoot-protein-db.so.0()(64bit)
    libcoot-shelx.so.0()(64bit)
    libcoot-skeleton.so.0()(64bit)
    libcoot-surface.so.0()(64bit)
    libcoot-tw.so.0()(64bit)
    libcoot-utils.so.0()(64bit)
    libcoot_py_restraints.so.0()(64bit)
    libcootaneer.so.0()(64bit)
    libcootilus.so.0()(64bit)
    python(abi)

coot-debuginfo (rpmlib, GLIBC filtered):

coot-doc (rpmlib, GLIBC filtered):
    coot

coot (rpmlib, GLIBC filtered):
    /bin/sh
    compat-guile18
    hicolor-icon-theme
    libAlignment.so.1()(64bit)
    libDataStructs.so.1()(64bit)
    libDepictor.so.1()(64bit)
    libDescriptors.so.1()(64bit)
    libDistGeomHelpers.so.1()(64bit)
    libDistGeometry.so.1()(64bit)
    libEigenSolvers.so.1()(64bit)
    libFileParsers.so.1()(64bit)
    libForceField.so.1()(64bit)
    libForceFieldHelpers.so.1()(64bit)
    libGL.so.1()(64bit)
    libGLU.so.1()(64bit)
    libGraphMol.so.1()(64bit)
    libICE.so.6()(64bit)
    libMolChemicalFeatures.so.1()(64bit)
    libMolDraw2D.so.1()(64bit)
    libOptimizer.so.1()(64bit)
    libRDGeneral.so.1()(64bit)
    libRDGeometryLib.so.1()(64bit)
    libSM.so.6()(64bit)
    libSmilesParse.so.1()(64bit)
    libSubstructMatch.so.1()(64bit)
    libX11.so.6()(64bit)
    libXmu.so.6()(64bit)
    libXt.so.6()(64bit)
    libart_lgpl_2.so.2()(64bit)
    libatk-1.0.so.0()(64bit)
    libboost_python.so.1.60.0()(64bit)
    libc.so.6()(64bit)
    libcairo.so.2()(64bit)
    libccp4c.so.0()(64bit)
    libccp4mg-surface.so.0()(64bit)
    libccp4mg-utils.so.0()(64bit)
    libclipper-ccp4.so.2()(64bit)
    libclipper-cif.so.2()(64bit)
    libclipper-cns.so.2()(64bit)
    libclipper-contrib.so.2()(64bit)
    libclipper-core.so.2()(64bit)
    libclipper-fortran.so.2()(64bit)
    libclipper-minimol.so.2()(64bit)
    libclipper-mmdb.so.2()(64bit)
    libclipper-phs.so.2()(64bit)
    libcoot-AngleInfo.so.0()(64bit)
    libcoot-analysis.so.0()(64bit)
    libcoot-cabuild.so.0()(64bit)
    libcoot-compat.so.0()(64bit)
    libcoot-coord-extras.so.0()(64bit)
    libcoot-coord-utils.so.0()(64bit)
    libcoot-coords.so.0()(64bit)
    libcoot-db-main.so.0()(64bit)
    libcoot-geometry.so.0()(64bit)
    libcoot-goograph.so.0()(64bit)
    libcoot-gtkgraph.so.0()(64bit)
    libcoot-high-res.so.0()(64bit)
    libcoot-ideal.so.0()(64bit)
    libcoot-isosurface.so.0()(64bit)
    libcoot-lidia-core.so.0()(64bit)
    libcoot-lidia.so.0()(64bit)
    libcoot-ligand.so.0()(64bit)
    libcoot-map-heavy.so.0()(64bit)
    libcoot-map-utils.so.0()(64bit)
    libcoot-mini-mol.so.0()(64bit)
    libcoot-protein-db.so.0()(64bit)
    libcoot-shelx.so.0()(64bit)
    libcoot-skeleton.so.0()(64bit)
    libcoot-surface.so.0()(64bit)
    libcoot-utils.so.0()(64bit)
    libcootaneer.so.0()(64bit)
    libcootilus.so.0()(64bit)
    libcurl.so.4()(64bit)
    libdl.so.2()(64bit)
    libfontconfig.so.1()(64bit)
    libfreetype.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgdk-x11-2.0.so.0()(64bit)
    libgdk_pixbuf-2.0.so.0()(64bit)
    libgdkglext-x11-1.0.so.0()(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libglut.so.3()(64bit)
    libgmodule-2.0.so.0()(64bit)
    libgnomecanvas-2.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgoocanvas.so.3()(64bit)
    libgsl.so.19()(64bit)
    libgslcblas.so.0()(64bit)
    libgtk-x11-2.0.so.0()(64bit)
    libgtkglext-x11-1.0.so.0()(64bit)
    libguile.so.17()(64bit)
    libm.so.6()(64bit)
    libmmdb2.so.0()(64bit)
    libpango-1.0.so.0()(64bit)
    libpangocairo-1.0.so.0()(64bit)
    libpangoft2-1.0.so.0()(64bit)
    libpangox-1.0.so.0()(64bit)
    libpng16.so.16()(64bit)
    libpthread.so.0()(64bit)
    libpython2.7.so.1.0()(64bit)
    libsfftw.so.2()(64bit)
    libsrfftw.so.2()(64bit)
    libssm.so.2()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.1)(64bit)
    libstdc++.so.6(CXXABI_1.3.8)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libutil.so.1()(64bit)
    python(abi)
    refmac-dictionary
    rtld(GNU_HASH)



Provides
--------
libcoot:
    libccp4mg-surface.so.0()(64bit)
    libccp4mg-utils.so.0()(64bit)
    libcoot
    libcoot(x86-64)
    libcoot-AngleInfo.so.0()(64bit)
    libcoot-analysis.so.0()(64bit)
    libcoot-cabuild.so.0()(64bit)
    libcoot-compat.so.0()(64bit)
    libcoot-coord-extras.so.0()(64bit)
    libcoot-coord-utils.so.0()(64bit)
    libcoot-coords.so.0()(64bit)
    libcoot-db-main.so.0()(64bit)
    libcoot-geometry.so.0()(64bit)
    libcoot-goograph.so.0()(64bit)
    libcoot-gtkgraph.so.0()(64bit)
    libcoot-high-res.so.0()(64bit)
    libcoot-ideal.so.0()(64bit)
    libcoot-isosurface.so.0()(64bit)
    libcoot-lidia-core.so.0()(64bit)
    libcoot-lidia.so.0()(64bit)
    libcoot-ligand.so.0()(64bit)
    libcoot-map-heavy.so.0()(64bit)
    libcoot-map-utils.so.0()(64bit)
    libcoot-mini-mol.so.0()(64bit)
    libcoot-protein-db.so.0()(64bit)
    libcoot-shelx.so.0()(64bit)
    libcoot-skeleton.so.0()(64bit)
    libcoot-surface.so.0()(64bit)
    libcoot-tw.so.0()(64bit)
    libcoot-utils.so.0()(64bit)
    libcoot_py_restraints.so.0()(64bit)
    libcootaneer.so.0()(64bit)
    libcootilus.so.0()(64bit)

libcoot-devel:
    libcoot-devel
    libcoot-devel(x86-64)

coot-debuginfo:
    coot-debuginfo
    coot-debuginfo(x86-64)

coot-doc:
    coot-doc

coot:
    appdata()
    appdata(coot.appdata.xml)
    application()
    application(coot.desktop)
    coot
    coot(x86-64)



Source checksums
----------------
http://www2.mrc-lmb.cam.ac.uk/Personal/pemsley/coot/source/releases/coot-0.8.6.2.tar.gz
:
  CHECKSUM(SHA256) this package     :
911eb76282c274e148d5351a689f428399c75f4cef7c121676a78b0a185f49c9
  CHECKSUM(SHA256) upstream package :
911eb76282c274e148d5351a689f428399c75f4cef7c121676a78b0a185f49c9
http://www2.mrc-lmb.cam.ac.uk/personal/pemsley/coot/dependencies/reference-structures.tar.gz
:
  CHECKSUM(SHA256) this package     :
44db38506f0f90c097d4855ad81a82a36b49cd1e3ffe7d6ee4728b15109e281a
  CHECKSUM(SHA256) upstream package :
44db38506f0f90c097d4855ad81a82a36b49cd1e3ffe7d6ee4728b15109e281a


AutoTools: Obsoleted m4s found
------------------------------
  AM_PROG_CC_STDC found in: coot-0.8.6.2/configure.ac:38


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1359402
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api, C/C++
Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]