https://bugzilla.redhat.com/show_bug.cgi?id=1359402 --- Comment #10 from Tim Fenn <tim.fenn@xxxxxxxxx> --- (In reply to Antonio Trande from comment #9) > > - hicolr-icon-theme should be a Requires package > Done. > - /usr/share/icons/hicolor/* directories are owned by hicolr-icon-theme. > You must list the coot.* image files only. > Done. > - All used licenses (GPLv2+ GPLv3+ LGPLv2+ LGPLv3+) are compatible among > them. > I think you can indicate GPLv3+ only as resultant license. > OK, so just switch this to GPLv3+ and delete all the other stuff? > - Use %python2_sitelib instead of %python_sitelib > Done. > - I would split off libcoot-* libraries in a separated libcoot sub-package > in order to obtain > > coot > libcoot > libcoot-devel > coot-doc > Done - I think I did this correctly - please check! > + > coot-data for all data files > > - Please, leave a comment about additional SourceX > Done. > - Spec use %global instead of %define unless justified > Done. > - Package should not use obsolete m4 macros > Note: Some obsoleted macros found, see the attachment. > See: https://fedorahosted.org/FedoraReview/wiki/AutoTools > Done. > - Please, fix unused-direct-shlib-dependency warnings > Done. I also updated to 0.8.6.2, which fixes the broken link issue. Also note I've included rdkit support now, as per a discussion with upstream and an additional patch. https://timfenn.fedorapeople.org/coot.spec https://timfenn.fedorapeople.org/coot-0.8.6.2-1.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx