https://bugzilla.redhat.com/show_bug.cgi?id=1388396 --- Comment #5 from Iryna Shcherbina <ishcherb@xxxxxxxxxx> --- Hey Dominika and Miro, thank you for the review and very useful comments. @Dominika * [!]: Requires correct, justified where necessary. Added a missing dependency, and specified the python version where possible. * [!]: License file installed when any subpackage combination is installed. Added license to python-pynlpl-doc package. * Current Source0 creates folder named "v1.0.9.tar.gz", it should be rather "pynlpl-1.0.9.tar.gz" Changed. * Used %{summary} macro. All above changes to the scpec file are available in the following commit: https://github.com/irushchyshyn/rpm_package/commit/4fbbf0e65e74aa5f787092bc25c855fb0b0f299a @Miro * Removed not needed package renaming. * Use Python 3 for docs generation. * Removed Python version from Python 3 executables. The changes are available in the following commit: https://github.com/irushchyshyn/rpm_package/commit/2431c712af57d0b55a7049b2833712c7fc183ff5 --------------- The docs generation tracebacks a lot, have a look at that and investigate please. Created an issue for upstream, to track the warnings and tracebacks: https://github.com/proycon/pynlpl/issues/23 Also created PRs to fix the tracebacks which were merged, so with the next release it will be fixed. New koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16259888 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx