[Bug 1388396] Review Request: python-pynlpl - A Python library for Natural Language Processing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1388396



--- Comment #4 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
You can use 

    %package doc

Instead of

    %package -n python-%{pkg_name}-doc

---------------

The docs generation tracebacks a lot, have a look at that and investigate
please.

---------------

The docs would be better generated with python 3 to show our love of Python 3,
however, if that would be too complicated, just keep it as is.

---------------

The links in /usr/bin should normally follow this pastern:

less specific -> more specific

I.e. the other way around than:

    /usr/bin/pynlpl-computepmi-3
    /usr/bin/pynlpl-computepmi-3.5 -> /usr/bin/pynlpl-computepmi-3
    /usr/bin/pynlpl-makefreqlist-3
    /usr/bin/pynlpl-makefreqlist-3.5 -> /usr/bin/pynlpl-makefreqlist-3
    /usr/bin/pynlpl-sampler-3
    /usr/bin/pynlpl-sampler-3.5 -> /usr/bin/pynlpl-sampler-3

Also, in this case I would say just omit the Python version at all, as the
version thing is there just to distinguish between the Python 2 and Python 3
executables and here the executables are only in Python 3 subpackage.

---------------

I was quite curious, how it is possible that after %py3_install there is stuff
in /usr/bin to move around and after %py2_install, there is none. So I've
looked at the sources and it's explicitly only allowed on Python 3, so it works
as expected. I recommend adding a comment after %py2_install, something like:

    # the executables are only installed on python 3 (by statement in setup.py)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]