https://bugzilla.redhat.com/show_bug.cgi?id=1390177 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok. Source archive (SHA-256: 7b6c36fb2ca4d57192a17bc9713cc07b7340aa46f74b22281e16b97c309049d2) is original. Ok. Summary verified from lib/Parallel/Pipes.pm. Ok. TODO: I recommend to replace the `pipe(2)' with `pipes' in the summary. Description verified from lib/Parallel/Pipes.pm. Ok. License verified from README, LICENSE, lib/Parallel/Pipes.pm. Ok. No XS code, noarch BuildArch is Ok. FIX: Build-require `sed' (perl-Parallel-Pipes.spec:35). TODO: I recommend to use $Config{startperl} instead of %__perl. The macro is a shell command and it won't work within SCL. Test::Pod is not used. Ok. All tests pass. Ok. $ rpmlint perl-Parallel-Pipes.spec ../SRPMS/perl-Parallel-Pipes-0.001-1.fc26.src.rpm ../RPMS/noarch/perl-Parallel-Pipes-0.001-1.fc26.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Parallel-Pipes-0.001-1.fc26.noarch.rpm drwxr-xr-x 2 root root 0 Oct 31 13:31 /usr/share/doc/perl-Parallel-Pipes -rw-r--r-- 1 root root 90 Aug 21 19:36 /usr/share/doc/perl-Parallel-Pipes/Changes -rw-r--r-- 1 root root 2498 Aug 21 19:36 /usr/share/doc/perl-Parallel-Pipes/README drwxr-xr-x 2 root root 0 Oct 31 13:31 /usr/share/doc/perl-Parallel-Pipes/eg -rw-r--r-- 1 root root 3802 Oct 31 13:31 /usr/share/doc/perl-Parallel-Pipes/eg/crawler.pl drwxr-xr-x 2 root root 0 Oct 31 13:31 /usr/share/licenses/perl-Parallel-Pipes -rw-r--r-- 1 root root 18400 Aug 21 19:36 /usr/share/licenses/perl-Parallel-Pipes/LICENSE -rw-r--r-- 1 root root 2127 Oct 31 13:31 /usr/share/man/man3/Parallel::Pipes.3pm.gz drwxr-xr-x 2 root root 0 Oct 31 13:31 /usr/share/perl5/vendor_perl/Parallel -rw-r--r-- 1 root root 8345 Aug 21 19:36 /usr/share/perl5/vendor_perl/Parallel/Pipes.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Parallel-Pipes-0.001-1.fc26.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.24.0) 1 perl(:VERSION) >= 5.8.1 1 perl(Carp) 1 perl(constant) 1 perl(IO::Handle) 1 perl(IO::Select) 1 perl(Storable) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Parallel-Pipes-0.001-1.fc26.noarch.rpm | sort -f | uniq -c 1 perl(Parallel::Pipe::Here) 1 perl(Parallel::Pipe::Impl) 1 perl(Parallel::Pipe::Impl::NoFork) 1 perl(Parallel::Pipe::There) 1 perl(Parallel::Pipes) = 0.001 1 perl-Parallel-Pipes = 0.001-1.fc26 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Parallel-Pipes-0.001-1.fc26.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F26 (http://koji.fedoraproject.org/koji/taskinfo?taskID=16259480). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx