https://bugzilla.redhat.com/show_bug.cgi?id=1267340 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |vondruch@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |vondruch@xxxxxxxxxx Flags| |fedora-review? --- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> --- I'm taking this for a review. * Update to the latest version - There seems to be 0.4.0 version available upstream. Please update the package to the latest version. * Integration test suite - You have 'rubygem(cucumber)' among your build dependencies, but you don't later execute the integration test suite using it. In theory, it should be as easy as calling "cucumber" in the %check section. If this is not possible, please remove the dependency and explain the reasons. - The "features" directory is actually source code of the integration tests suite, it should not be required for runtime and hance it belong to -doc subpackage (actually you exclude the "test" directory from the package, so you probably want to exclude "features" directory as well). - The "config" directory looks to be used just by integration test suite, so it should follow the same fate as the "features" and "test" directories. Otherwise the package looks sane. I'll finish the review as soon as you'll update to the latest version. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx