https://bugzilla.redhat.com/show_bug.cgi?id=1381548 Petr Menšík <pemensik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Petr Menšík <pemensik@xxxxxxxxxx> --- [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package complies to the Packaging Guidelines [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec file according to URL is the same as in SRPM. Ok, all other ODBC plugins are there, they can be moved to plugins directory later. Some fixes of mariadb-connector-c are wrong, but that is not what I review. I think mariadb-connector-c is used as ordinary library by ODBC and should be therefore installed as ordinary library in %{_libdir}. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx