[Bug 1381548] Review Request: mariadb-connector-odbc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1381548



--- Comment #4 from Michal Schorm <mschorm@xxxxxxxxxx> ---
Third review request:

* %{_libdir}/mariadb/ added as into %files section of package
mariadb-connector-c-devel and RPATH was fixed. New release (2.3.1-2.fc26) is on
its way to rawhide repo by now.

Reason:
You can install mariadb-connector-c as a part of mariadb (so mariadb owns the
libdir/mariadb directory).
But the goal of mariadb-connector-c, which can be used as a standalone package
in various use-cases, is to offer its functionality without whole mariadb. (For
example if mariadb-server is remote) 
That's why mariadb-connector-c-devel (which place library in libdir/mariadb)
must own libdir/mariadb directory.

* libmaodbc.so should stay directly in %{_libdir}

Reason:
mariadb-connector-odbc is NOT mariadb plugin. To be exact, it is unix-odbc
plugin. To preserve consistency, it should reside, where all other unixODBC
plugins are - directly in %{_libdir} directory.

Note:
In order to Packaging guidelines, (1) plugins libraries don't need to be
versioned and (2) NONE unversioned libraries should be directly in libdir.
The only right solution would be to move ALL unix-odbc plugins from all
associated packages to their new libdir/unixodbc directory at once.  

_____

SPEC and url did not change, the now point to updated version.
SRPM url update to:
https://raw.githubusercontent.com/FaramosCZ/Fedora-maintain/master/mariadb/mariadb-connector-odbc/SRPMS/mariadb-connector-odbc-2.0.12-1.fc26.src.rpm
Old version can be found on GitHub in "Version 1" and "Version 2" branches.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]