[Bug 1373641] Review Request: setBfree - A DSP Tonewheel Organ emulator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1373641



--- Comment #8 from Guido Aulisi <guido.aulisi@xxxxxxxxx> ---
Hi Fabio and  Michael
thanks for your suggestions.

I will try to explain and address the things you reported:

1. I made a pull request on github to correct FSF address and version number
and it has been accepted, so the next version will be ok. I didn't make a PR
for the lv2 path, because there is a conflict between Fedora guidelines for 64
bit lv2 libraries path (/usr/lib64/lv2) and the lv2 spec (PREFIX/lib/lv2), see
http://lv2plug.in/pages/filesystem-hierarchy-standard.html, and I know that
this change would be rejected, so I think it's better to keep the Makefile
patch.

2. The setBfree and lv2-setBfree-plugins are independent, the first one is the
standalone version, it works on top of the Jack audio server; the second one is
the LV2 plugin version, it needs an LV2 host like ardour (http://ardour.org).
You can install one of the two or both as you like.

3. For the reasons in 2, I made the common package, which contains the common
files, doc and license. It's installed as a dependency when you install one or
both of the main packages.

> Requires:       lv2 >= 1.8.1
Should I remove minimum version? I always see this Require in lv2 plugin
packages, see for exmple
http://pkgs.fedoraproject.org/cgit/rpms/lv2-EQ10Q-plugins.git/plain/lv2-EQ10Q-plugins.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]