https://bugzilla.redhat.com/show_bug.cgi?id=1375962 --- Comment #6 from Julien Enselme <jujens@xxxxxxxxx> --- > I have to say that I'm not a fan of macros that are only used one or a few times, like %cmdname, %project_owner, etc. They make c&p unnecessarily hard, and IMO decrease readability. And if you use this spec as a template for another package, search-and-replace can be used to update all the names in 3s. Anyway, just an opinion. I have no strong opinion on this. I initially wrote the spec without cmdname. I'll leave it as this for now. I may change my mind later. > %{_sbindir}/update-alternatives → /sbin has been in $PATH in Fedora for years, so there's absolutely no need to specify the full path. Good to know. Corrected. > patterns are duplicated in %files Indeed, corrected. Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx