https://bugzilla.redhat.com/show_bug.cgi?id=1375962 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags| |fedora-review+ --- Comment #5 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- I have to say that I'm not a fan of macros that are only used one or a few times, like %cmdname, %project_owner, etc. They make c&p unnecessarily hard, and IMO decrease readability. And if you use this spec as a template for another package, search-and-replace can be used to update all the names in 3s. Anyway, just an opinion. %{_sbindir}/update-alternatives → /sbin has been in $PATH in Fedora for years, so there's absolutely no need to specify the full path. warning: File listed twice: /usr/bin/sphinx-intl-3 warning: File listed twice: /usr/bin/sphinx-intl-3.5 warning: File listed twice: /usr/bin/sphinx-intl-2 warning: File listed twice: /usr/bin/sphinx-intl-2.7 → patterns are duplicated in %files + package name is OK + license is acceptable for Fedora (BSD) + license is specified correctly + latest version + python packaging template is used + %python_provide is used + python3 is supported + executables in /bin are properly versioned and symlinked + builds and installs OK + provides/requires look sane Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx