[Bug 1381935] Review Request: python-distro - Linux Distribution - a Linux OS platform information API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1381935



--- Comment #7 from Miroslav Suchý <msuchy@xxxxxxxxxx> ---
> A simpler way to do the %install phase is to simply re-order it ...

Done.

> The conditional inside the Python 3 subpackage conditional for the files list is redundant.

Fixed.

> * Your rpm changelog is in the wrong format (lacks email address)

a) I have misconfigured Tito (which create that entries for me). It have email
now.
b) The email address is not mandatory. It is actually optional. Albeit most
maintainers use it.

> and has a duplicate entry rather than unique entries.

I actually done so many releases. Only after that I found some problem so I
created another release. So it really reflect what I have been doing. I prefer
it over keeping the same release number for all intermittent releases.

Updated:
Spec URL: http://miroslav.suchy.cz/fedora/python-distro/python-distro.spec
SRPM URL:
http://miroslav.suchy.cz/fedora/python-distro/python-distro-1.0.0-6.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]