https://bugzilla.redhat.com/show_bug.cgi?id=1381935 --- Comment #6 from Neal Gompa <ngompa13@xxxxxxxxx> --- Comments and issues: * A simpler way to do the %install phase is to simply re-order it so that %py2_install occurs first, then %py3_install next. That should properly overwrite /usr/bin/distro. After all, the only case where you have /usr/bin/distro point to Python 2 is when the Python 3 subpackage doesn't exist. * The conditional inside the Python 3 subpackage conditional for the files list is redundant. You're already going to have /usr/bin/distro in the python3 subpackage if it's being built. * Your rpm changelog is in the wrong format (lacks email address) and has a duplicate entry rather than unique entries. * It's fine with not using a macro for the description. That's purely a preference. You've fixed the description in each subpackage, which is enough. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx