https://bugzilla.redhat.com/show_bug.cgi?id=1290337 Christoph Junghans <junghans@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #4 from Christoph Junghans <junghans@xxxxxxxxx> --- (In reply to gil cattaneo from comment #3) > (In reply to Christoph Junghans from comment #2) > > 3 questions: > > - Does it make sense to install the javadoc without the actual package - > > Missing "Require:"? > No > > [?]: Fully versioned dependency in subpackages if applicable. > > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ed25519 > > -java-javadoc > > Requires are handled by our: java(packages-)tools > and this is a noarch package. for refrerences see: > https://fedora-java.github.io/howto/latest/#maven Thanks for the explanation. > > > [?]: If package contains pom.xml files install it (including metadata) even > > when building with ant > > > - pom.xml isn't packaged, why? > > is not true see "Provides" mvn(net.i2p.crypto:eddsa:pom:) Found it /usr/share/maven-poms/ed25519-java.pom > > > [?]: %check is present and all tests pass. > > > - There seem to be tests in test/net/i2p/crypto/eddsa, but no %check > > This is a maven build style and "%check" is useless only in this case (and > with gradle) I see! Thanks for all the pointers, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx