[Bug 1290337] Review Request: ed25519-java - Implementation of EdDSA ( Ed25519) in Java

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1290337



--- Comment #3 from gil cattaneo <puntogil@xxxxxxxxx> ---
(In reply to Christoph Junghans from comment #2)
> 3 questions:
> - Does it make sense to install the javadoc without the actual package -
> Missing "Require:"?
No
> [?]: Fully versioned dependency in subpackages if applicable.
>      Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ed25519
>      -java-javadoc

Requires are handled by our: java(packages-)tools
and this is a noarch package. for refrerences see:
https://fedora-java.github.io/howto/latest/#maven

> [?]: If package contains pom.xml files install it (including metadata) even
>      when building with ant

> - pom.xml isn't packaged, why?

is not true see "Provides" mvn(net.i2p.crypto:eddsa:pom:)

> [?]: %check is present and all tests pass.

> - There seem to be tests in test/net/i2p/crypto/eddsa, but no %check

This is a maven build style and "%check" is useless only in this case (and with
gradle)


> Requires
> --------
> ed25519-java (rpmlib, GLIBC filtered):
>     java-headless
>     javapackages-tools
> 
> ed25519-java-javadoc (rpmlib, GLIBC filtered):
>     javapackages-tools
> 
> 
> 
> Provides
> --------
> ed25519-java:
>     ed25519-java
>     mvn(net.i2p.crypto:eddsa)
>     mvn(net.i2p.crypto:eddsa:pom:)
>     osgi(net.i2p.crypto.eddsa)
>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]